From: "Joseph S. Myers" <joseph@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Disable gdb.mi environment-pwd tests for remote-host testing
Date: Tue, 18 Aug 2009 16:42:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.0908181634470.10638@digraph.polyomino.org.uk> (raw)
When doing remote-host testing, it is generally necessary that any path
that is available on the build system and used in testing (the source and
object directories, in particular) is also available on the host system
with the same contents (that is, a shared filesystem is used). In theory
it is not needed, but most DejaGnu testsuites do not do all the copying
between build and host systems that is required to work without a shared
filesystem.
Although the path must be available on both systems, the canonical form
may not be the same on both systems (for example, the path on the host may
be a symlink to a /net automount from the build system, or the host may
have a different OS using different path conventions). mi-basics.exp and
mi2-basics.exp contain tests of environment-pwd which are thus
inappropriate in the remote-host case, since this command calls getcwd
which may return a canonical path for the host, not the same as the path
on the build system. This patch disables the problematic tests for the
remote-host case. OK to commit?
2009-08-18 Joseph Myers <joseph@codesourcery.com>
* gdb.mi/mi-basics.exp (test_cwd_specification): Do not test
environment-pwd for remote host.
* gdb.mi/mi2-basics.exp (test_cwd_specification): Likewise.
Index: gdb/testsuite/gdb.mi/mi-basics.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-basics.exp,v
retrieving revision 1.22
diff -u -r1.22 mi-basics.exp
--- gdb/testsuite/gdb.mi/mi-basics.exp 9 Jun 2009 17:12:42 -0000 1.22
+++ gdb/testsuite/gdb.mi/mi-basics.exp 18 Aug 2009 16:34:12 -0000
@@ -184,9 +184,11 @@
"205\\\^done" \
"environment-cd arg operation"
- mi_gdb_test "206-environment-pwd" \
+ if ![is_remote host] {
+ mi_gdb_test "206-environment-pwd" \
"206\\\^done,cwd=\"${escapedobjdir}\"" \
"environment-pwd operation"
+ }
}
proc test_path_specification {} {
Index: gdb/testsuite/gdb.mi/mi2-basics.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-basics.exp,v
retrieving revision 1.14
diff -u -r1.14 mi2-basics.exp
--- gdb/testsuite/gdb.mi/mi2-basics.exp 9 Jun 2009 17:12:43 -0000 1.14
+++ gdb/testsuite/gdb.mi/mi2-basics.exp 18 Aug 2009 16:34:12 -0000
@@ -186,9 +186,11 @@
"205\\\^done" \
"environment-cd arg operation"
- mi_gdb_test "206-environment-pwd" \
+ if ![is_remote host] {
+ mi_gdb_test "206-environment-pwd" \
"206\\\^done,cwd=\"${escapedobjdir}\"" \
"environment-pwd operation"
+ }
}
proc test_path_specification {} {
--
Joseph S. Myers
joseph@codesourcery.com
next reply other threads:[~2009-08-18 16:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 16:42 Joseph S. Myers [this message]
2009-08-19 7:56 ` Vladimir Prus
2009-08-26 19:22 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0908181634470.10638@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox