Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <vladimir@codesourcery.com>
To: gdb-patches@sources.redhat.com
Subject: Re: Disable gdb.mi environment-pwd tests for remote-host testing
Date: Wed, 19 Aug 2009 07:56:00 -0000	[thread overview]
Message-ID: <h6g25c$ege$1@ger.gmane.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0908181634470.10638@digraph.polyomino.org.uk>

Joseph S. Myers wrote:

> When doing remote-host testing, it is generally necessary that any path
> that is available on the build system and used in testing (the source and
> object directories, in particular) is also available on the host system
> with the same contents (that is, a shared filesystem is used).  In theory
> it is not needed, but most DejaGnu testsuites do not do all the copying
> between build and host systems that is required to work without a shared
> filesystem.
> 
> Although the path must be available on both systems, the canonical form
> may not be the same on both systems (for example, the path on the host may
> be a symlink to a /net automount from the build system, or the host may
> have a different OS using different path conventions).  mi-basics.exp and
> mi2-basics.exp contain tests of environment-pwd which are thus
> inappropriate in the remote-host case, since this command calls getcwd
> which may return a canonical path for the host, not the same as the path
> on the build system.  This patch disables the problematic tests for the
> remote-host case.  OK to commit?

This patch is OK. However, please add a comment in the testcase explaining
why the test is not run for remote host testing -- some condensed form of
the above.

Thanks,
Volodya




  reply	other threads:[~2009-08-19  5:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-18 16:42 Joseph S. Myers
2009-08-19  7:56 ` Vladimir Prus [this message]
2009-08-26 19:22   ` Joseph S. Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='h6g25c$ege$1@ger.gmane.org' \
    --to=vladimir@codesourcery.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox