From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19568 invoked by alias); 18 Aug 2009 16:41:12 -0000 Received: (qmail 19559 invoked by uid 22791); 18 Aug 2009 16:41:10 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_32,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Aug 2009 16:41:03 +0000 Received: (qmail 30654 invoked from network); 18 Aug 2009 16:41:01 -0000 Received: from unknown (HELO digraph.polyomino.org.uk) (joseph@127.0.0.2) by mail.codesourcery.com with ESMTPA; 18 Aug 2009 16:41:01 -0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.69) (envelope-from ) id 1MdRk4-0004iT-CN for gdb-patches@sourceware.org; Tue, 18 Aug 2009 16:41:00 +0000 Date: Tue, 18 Aug 2009 16:42:00 -0000 From: "Joseph S. Myers" To: gdb-patches@sourceware.org Subject: Disable gdb.mi environment-pwd tests for remote-host testing Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00283.txt.bz2 When doing remote-host testing, it is generally necessary that any path that is available on the build system and used in testing (the source and object directories, in particular) is also available on the host system with the same contents (that is, a shared filesystem is used). In theory it is not needed, but most DejaGnu testsuites do not do all the copying between build and host systems that is required to work without a shared filesystem. Although the path must be available on both systems, the canonical form may not be the same on both systems (for example, the path on the host may be a symlink to a /net automount from the build system, or the host may have a different OS using different path conventions). mi-basics.exp and mi2-basics.exp contain tests of environment-pwd which are thus inappropriate in the remote-host case, since this command calls getcwd which may return a canonical path for the host, not the same as the path on the build system. This patch disables the problematic tests for the remote-host case. OK to commit? 2009-08-18 Joseph Myers * gdb.mi/mi-basics.exp (test_cwd_specification): Do not test environment-pwd for remote host. * gdb.mi/mi2-basics.exp (test_cwd_specification): Likewise. Index: gdb/testsuite/gdb.mi/mi-basics.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-basics.exp,v retrieving revision 1.22 diff -u -r1.22 mi-basics.exp --- gdb/testsuite/gdb.mi/mi-basics.exp 9 Jun 2009 17:12:42 -0000 1.22 +++ gdb/testsuite/gdb.mi/mi-basics.exp 18 Aug 2009 16:34:12 -0000 @@ -184,9 +184,11 @@ "205\\\^done" \ "environment-cd arg operation" - mi_gdb_test "206-environment-pwd" \ + if ![is_remote host] { + mi_gdb_test "206-environment-pwd" \ "206\\\^done,cwd=\"${escapedobjdir}\"" \ "environment-pwd operation" + } } proc test_path_specification {} { Index: gdb/testsuite/gdb.mi/mi2-basics.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-basics.exp,v retrieving revision 1.14 diff -u -r1.14 mi2-basics.exp --- gdb/testsuite/gdb.mi/mi2-basics.exp 9 Jun 2009 17:12:43 -0000 1.14 +++ gdb/testsuite/gdb.mi/mi2-basics.exp 18 Aug 2009 16:34:12 -0000 @@ -186,9 +186,11 @@ "205\\\^done" \ "environment-cd arg operation" - mi_gdb_test "206-environment-pwd" \ + if ![is_remote host] { + mi_gdb_test "206-environment-pwd" \ "206\\\^done,cwd=\"${escapedobjdir}\"" \ "environment-pwd operation" + } } proc test_path_specification {} { -- Joseph S. Myers joseph@codesourcery.com