Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Karen Osmond <karen.osmond@gmail.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] not able to set pending breakpoint at qualified C++   function  names
Date: Mon, 22 Jun 2009 21:29:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.64.0906222224580.32368@localhost.localdomain> (raw)
In-Reply-To: <m3bpp3wtwk.fsf@fleche.redhat.com>

On Thu, 4 Jun 2009, Tom Tromey wrote:

> >>>>> "Karen" == Karen Osmond <karen.osmond@gmail.com> writes:
> 
> Karen> 2009-06-03  Karen Osmond  <karen.osmond@gmail.com>
> Karen> 	* linespec.c (find_method): Add new not_found_ptr parameter to
> Karen> 	bring in line with symtab_from_filename, decode_variable.
> Karen> 	(decode_compound): Likewise.  Also propagate not_found_ptr to 
> Karen> 	find_method.
> Karen> 	(decode_line_1): Propagage not_found_ptr to decode_compound.
> 
> Typo in "propagate".
> 
> Karen> 	(cplusplus_error): Now throws NOT_FOUND_ERROR.
> 
> Other than the typo, looks good to me.  This is ok once your paperwork
> completes.  Send a note to the list when that happens and someone will
> check this in.

Paperwork is now sorted - please could somebody commit?

The patch can be found here:
http://sourceware.org/ml/gdb-patches/2009-06/msg00034.html

And here's the ChangeLog again, with typo corrected:

2009-06-22  Karen Osmond  <karen.osmond@gmail.com>

	* linespec.c (find_method): Add new not_found_ptr parameter to
	bring in line with symtab_from_filename, decode_variable.
	(decode_compound): Likewise.  Also propagate not_found_ptr to 
	find_method.
	(decode_line_1): Propagate not_found_ptr to decode_compound.
	(cplusplus_error): Now throws NOT_FOUND_ERROR.

cheers,
-karen.


  reply	other threads:[~2009-06-22 21:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-11 19:07 Karen Osmond
2009-04-29  1:03 ` Tom Tromey
2009-06-03 13:56   ` Karen Osmond
2009-06-04 21:50     ` Tom Tromey
2009-06-22 21:29       ` Karen Osmond [this message]
2009-06-25 18:09         ` Karen Osmond
2009-06-25 23:21           ` [patch] Test result regression for gdb.base/psymtab.exp [Re: [patch] not able to set pending breakpoint at qualified C++ function names] Jan Kratochvil
2009-06-26 14:50             ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0906222224580.32368@localhost.localdomain \
    --to=karen.osmond@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox