From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-64705-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30592 invoked by alias); 22 Jun 2009 21:29:23 -0000
Received: (qmail 30582 invoked by uid 22791); 22 Jun 2009 21:29:22 -0000
X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 	tests=AWL,BAYES_00,SPF_NEUTRAL
X-Spam-Check-By: sourceware.org
Received: from honeysuckle.london.02.net (HELO honeysuckle.london.02.net) (87.194.255.144)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 22 Jun 2009 21:29:15 +0000
Received: from elm.config (87.194.37.195) by honeysuckle.london.02.net (8.5.016.1)         id 4A23EDE60152EBB1; Mon, 22 Jun 2009 22:28:35 +0100
Date: Mon, 22 Jun 2009 21:29:00 -0000
From: Karen Osmond <karen.osmond@gmail.com>
Reply-To: karen.osmond@gmail.com
To: Tom Tromey <tromey@redhat.com>
cc: gdb-patches@sourceware.org
Subject: Re: [patch] not able to set pending breakpoint at qualified C++   function  names
In-Reply-To: <m3bpp3wtwk.fsf@fleche.redhat.com>
Message-ID: <Pine.LNX.4.64.0906222224580.32368@localhost.localdomain>
References: <Pine.LNX.4.64.0902111855170.2518@localhost.localdomain>  <m3ws94fezf.fsf@fleche.redhat.com> <Pine.LNX.4.64.0906031434140.32368@localhost.localdomain>  <m3bpp3wtwk.fsf@fleche.redhat.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-06/txt/msg00592.txt.bz2

On Thu, 4 Jun 2009, Tom Tromey wrote:

> >>>>> "Karen" == Karen Osmond <karen.osmond@gmail.com> writes:
> 
> Karen> 2009-06-03  Karen Osmond  <karen.osmond@gmail.com>
> Karen> 	* linespec.c (find_method): Add new not_found_ptr parameter to
> Karen> 	bring in line with symtab_from_filename, decode_variable.
> Karen> 	(decode_compound): Likewise.  Also propagate not_found_ptr to 
> Karen> 	find_method.
> Karen> 	(decode_line_1): Propagage not_found_ptr to decode_compound.
> 
> Typo in "propagate".
> 
> Karen> 	(cplusplus_error): Now throws NOT_FOUND_ERROR.
> 
> Other than the typo, looks good to me.  This is ok once your paperwork
> completes.  Send a note to the list when that happens and someone will
> check this in.

Paperwork is now sorted - please could somebody commit?

The patch can be found here:
http://sourceware.org/ml/gdb-patches/2009-06/msg00034.html

And here's the ChangeLog again, with typo corrected:

2009-06-22  Karen Osmond  <karen.osmond@gmail.com>

	* linespec.c (find_method): Add new not_found_ptr parameter to
	bring in line with symtab_from_filename, decode_variable.
	(decode_compound): Likewise.  Also propagate not_found_ptr to 
	find_method.
	(decode_line_1): Propagate not_found_ptr to decode_compound.
	(cplusplus_error): Now throws NOT_FOUND_ERROR.

cheers,
-karen.