From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>,
Karen Osmond <karen.osmond@gmail.com>,
Doug Evans <dje@google.com>
Subject: Re: [patch] Test result regression for gdb.base/psymtab.exp [Re: [patch] not able to set pending breakpoint at qualified C++ function names]
Date: Fri, 26 Jun 2009 14:50:00 -0000 [thread overview]
Message-ID: <200906261551.17580.pedro@codesourcery.com> (raw)
In-Reply-To: <20090625232112.GA27525@host0.dyn.jankratochvil.net>
On Friday 26 June 2009 00:21:12, Jan Kratochvil wrote:
> +# GDB now correctly asks if the symbol can be found on future library load.
> +
> +gdb_test "set breakpoint pending off"
> +
I was going to say: okay, but please refrase the comment to not
say "now correctly asks", as "now" is relative. In a few years,
it will look outdated. But I just saw Doug's patch addressing
the same issue, and his comment is nicer. :-) :-P
If everyone's fine with it, let's go with Doug's version.
--
Pedro Alves
prev parent reply other threads:[~2009-06-26 14:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 19:07 [patch] not able to set pending breakpoint at qualified C++ function names Karen Osmond
2009-04-29 1:03 ` Tom Tromey
2009-06-03 13:56 ` Karen Osmond
2009-06-04 21:50 ` Tom Tromey
2009-06-22 21:29 ` Karen Osmond
2009-06-25 18:09 ` Karen Osmond
2009-06-25 23:21 ` [patch] Test result regression for gdb.base/psymtab.exp [Re: [patch] not able to set pending breakpoint at qualified C++ function names] Jan Kratochvil
2009-06-26 14:50 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906261551.17580.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=karen.osmond@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox