From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11911 invoked by alias); 26 Jun 2009 14:50:38 -0000 Received: (qmail 11901 invoked by uid 22791); 26 Jun 2009 14:50:37 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 26 Jun 2009 14:50:29 +0000 Received: (qmail 8318 invoked from network); 26 Jun 2009 14:50:27 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 26 Jun 2009 14:50:27 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [patch] Test result regression for gdb.base/psymtab.exp [Re: [patch] not able to set pending breakpoint at qualified C++ function names] Date: Fri, 26 Jun 2009 14:50:00 -0000 User-Agent: KMail/1.9.10 Cc: Jan Kratochvil , Karen Osmond , Doug Evans References: <20090625232112.GA27525@host0.dyn.jankratochvil.net> In-Reply-To: <20090625232112.GA27525@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <200906261551.17580.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00712.txt.bz2 On Friday 26 June 2009 00:21:12, Jan Kratochvil wrote: > +# GDB now correctly asks if the symbol can be found on future library load. > + > +gdb_test "set breakpoint pending off" > + I was going to say: okay, but please refrase the comment to not say "now correctly asks", as "now" is relative. In a few years, it will look outdated. But I just saw Doug's patch addressing the same issue, and his comment is nicer. :-) :-P If everyone's fine with it, let's go with Doug's version. -- Pedro Alves