From: "Maciej W. Rozycki" <macro@mips.com>
To: gdb-patches@sourceware.org
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: gdb.base/break.exp: Mark failures as such
Date: Fri, 28 Mar 2008 16:32:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.61.0803281623570.1324@perivale.mips.com> (raw)
Hello,
A few tests in gdb.base/break.exp incorrectly flag their catch-all
pattern as a success. Here is a fix, including some reformatting which
actually makes makes them readable (the current opposite state probably
being responsible for the problem).
2008-03-28 Maciej W. Rozycki <macro@mips.com>
* gdb.base/break.exp: Mark failures as such. Fix formatting.
Almost obvious, but just in case: OK to apply?
Maciej
14589.diff
Index: gdb/src/gdb/testsuite/gdb.base/break.exp
===================================================================
--- gdb.orig/src/gdb/testsuite/gdb.base/break.exp 2007-02-13 16:35:28.000000000 +0000
+++ gdb/src/gdb/testsuite/gdb.base/break.exp 2007-02-13 16:40:43.000000000 +0000
@@ -298,9 +298,15 @@
#
send_gdb "tbreak $bp_location1\n"
gdb_expect {
- -re "Breakpoint.*at.* file .*$srcfile, line $bp_location1.*$gdb_prompt $" { pass "Temporary breakpoint line number #1" }
- -re ".*$gdb_prompt $" { pass "Temporary breakpoint line number #1" }
- timeout { fail "breakpoint line number #1 (timeout)" }
+ -re "Breakpoint.*at.* file .*$srcfile, line $bp_location1.*$gdb_prompt $" {
+ pass "Temporary breakpoint line number #1"
+ }
+ -re ".*$gdb_prompt $" {
+ fail "Temporary breakpoint line number #1"
+ }
+ timeout {
+ fail "breakpoint line number #1 (timeout)"
+ }
}
gdb_test "tbreak $bp_location6" "Breakpoint.*at.* file .*$srcfile, line $bp_location6.*" "Temporary breakpoint line number #2"
@@ -310,9 +316,15 @@
#
send_gdb "tbreak $srcfile:$bp_location2\n"
gdb_expect {
- -re "Breakpoint.*at.* file .*$srcfile, line $bp_location2.*$gdb_prompt $" { pass "Temporary breakpoint line number in file #1" }
- -re ".*$gdb_prompt $" { pass "Temporary breakpoint line number in file #1" }
- timeout { fail "Temporary breakpoint line number in file #1 (timeout)" }
+ -re "Breakpoint.*at.* file .*$srcfile, line $bp_location2.*$gdb_prompt $" {
+ pass "Temporary breakpoint line number in file #1"
+ }
+ -re ".*$gdb_prompt $" {
+ fail "Temporary breakpoint line number in file #1"
+ }
+ timeout {
+ fail "Temporary breakpoint line number in file #1 (timeout)"
+ }
}
set bp_location11 [gdb_get_line_number "set breakpoint 11 here"]
next reply other threads:[~2008-03-28 16:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 16:32 Maciej W. Rozycki [this message]
2008-03-30 22:25 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0803281623570.1324@perivale.mips.com \
--to=macro@mips.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox