From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-54832-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13134 invoked by alias); 28 Mar 2008 16:32:28 -0000
Received: (qmail 13117 invoked by uid 22791); 28 Mar 2008 16:32:27 -0000
X-Spam-Check-By: sourceware.org
Received: from dmz.mips-uk.com (HELO dmz.mips-uk.com) (194.74.144.194)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 28 Mar 2008 16:32:09 +0000
Received: from internal-mx1 ([192.168.192.240] helo=ukservices1.mips.com) 	by dmz.mips-uk.com with esmtp (Exim 3.35 #1 (Debian)) 	id 1JfHUt-0006kF-00; Fri, 28 Mar 2008 16:32:07 +0000
Received: from perivale.mips.com ([192.168.192.200]) 	by ukservices1.mips.com with esmtp (Exim 3.36 #1 (Debian)) 	id 1JfHUn-0003tI-00; Fri, 28 Mar 2008 16:32:01 +0000
Received: from macro (helo=localhost) 	by perivale.mips.com with local-esmtp (Exim 4.63) 	(envelope-from <macro@mips.com>) 	id 1JfHUn-0003ZI-0W; Fri, 28 Mar 2008 16:32:01 +0000
Date: Fri, 28 Mar 2008 16:32:00 -0000
From: "Maciej W. Rozycki" <macro@mips.com>
To: gdb-patches@sourceware.org
cc: "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: gdb.base/break.exp: Mark failures as such
Message-ID: <Pine.LNX.4.61.0803281623570.1324@perivale.mips.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-MIPS-Technologies-UK-MailScanner: Found to be clean
X-MIPS-Technologies-UK-MailScanner-From: macro@mips.com
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-03/txt/msg00474.txt.bz2

Hello,

 A few tests in gdb.base/break.exp incorrectly flag their catch-all 
pattern as a success.  Here is a fix, including some reformatting which 
actually makes makes them readable (the current opposite state probably 
being responsible for the problem).

2008-03-28  Maciej W. Rozycki  <macro@mips.com>

	* gdb.base/break.exp: Mark failures as such.  Fix formatting.

 Almost obvious, but just in case: OK to apply?

  Maciej

14589.diff
Index: gdb/src/gdb/testsuite/gdb.base/break.exp
===================================================================
--- gdb.orig/src/gdb/testsuite/gdb.base/break.exp	2007-02-13 16:35:28.000000000 +0000
+++ gdb/src/gdb/testsuite/gdb.base/break.exp	2007-02-13 16:40:43.000000000 +0000
@@ -298,9 +298,15 @@
 #
 send_gdb "tbreak $bp_location1\n"
 gdb_expect {
-    -re "Breakpoint.*at.* file .*$srcfile, line $bp_location1.*$gdb_prompt $" { pass "Temporary breakpoint line number #1" }
-	-re ".*$gdb_prompt $"   { pass "Temporary breakpoint line number #1" }
-	timeout	    { fail "breakpoint line number #1 (timeout)" }
+    -re "Breakpoint.*at.* file .*$srcfile, line $bp_location1.*$gdb_prompt $" {
+	pass "Temporary breakpoint line number #1"
+    }
+    -re ".*$gdb_prompt $" {
+	fail "Temporary breakpoint line number #1"
+    }
+    timeout {
+	fail "breakpoint line number #1 (timeout)"
+    }
 }
 
 gdb_test "tbreak $bp_location6" "Breakpoint.*at.* file .*$srcfile, line $bp_location6.*" "Temporary breakpoint line number #2"
@@ -310,9 +316,15 @@
 #
 send_gdb "tbreak $srcfile:$bp_location2\n"
 gdb_expect {
-    -re "Breakpoint.*at.* file .*$srcfile, line $bp_location2.*$gdb_prompt $" { pass "Temporary breakpoint line number in file #1" }
-	-re ".*$gdb_prompt $"   { pass "Temporary breakpoint line number in file #1" }
-	timeout	    { fail "Temporary breakpoint line number in file #1 (timeout)" }
+    -re "Breakpoint.*at.* file .*$srcfile, line $bp_location2.*$gdb_prompt $" {
+	pass "Temporary breakpoint line number in file #1"
+    }
+    -re ".*$gdb_prompt $" {
+	fail "Temporary breakpoint line number in file #1"
+    }
+    timeout {
+	fail "Temporary breakpoint line number in file #1 (timeout)"
+    }
 }
 
 set bp_location11 [gdb_get_line_number "set breakpoint 11 here"]