From: Daniel Jacobowitz <drow@false.org>
To: "Maciej W. Rozycki" <macro@mips.com>
Cc: gdb-patches@sourceware.org, "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: gdb.base/break.exp: Mark failures as such
Date: Sun, 30 Mar 2008 22:25:00 -0000 [thread overview]
Message-ID: <20080330222517.GA5747@caradoc.them.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0803281623570.1324@perivale.mips.com>
On Fri, Mar 28, 2008 at 04:32:00PM +0000, Maciej W. Rozycki wrote:
> Hello,
>
> A few tests in gdb.base/break.exp incorrectly flag their catch-all
> pattern as a success. Here is a fix, including some reformatting which
> actually makes makes them readable (the current opposite state probably
> being responsible for the problem).
>
> 2008-03-28 Maciej W. Rozycki <macro@mips.com>
>
> * gdb.base/break.exp: Mark failures as such. Fix formatting.
>
> Almost obvious, but just in case: OK to apply?
OK.
> + -re ".*$gdb_prompt $" {
> + fail "Temporary breakpoint line number #1"
> + }
> + timeout {
> + fail "breakpoint line number #1 (timeout)"
> + }
Could you fix the test name in the timeout fail, too?
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2008-03-30 22:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 16:32 Maciej W. Rozycki
2008-03-30 22:25 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080330222517.GA5747@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=macro@linux-mips.org \
--cc=macro@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox