From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-54848-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4855 invoked by alias); 30 Mar 2008 22:25:40 -0000
Received: (qmail 4842 invoked by uid 22791); 30 Mar 2008 22:25:39 -0000
X-Spam-Check-By: sourceware.org
Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 30 Mar 2008 22:25:20 +0000
Received: from nan.false.org (localhost [127.0.0.1]) 	by nan.false.org (Postfix) with ESMTP id B74E0983BE; 	Sun, 30 Mar 2008 22:25:18 +0000 (GMT)
Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) 	by nan.false.org (Postfix) with ESMTP id 98AA69802B; 	Sun, 30 Mar 2008 22:25:18 +0000 (GMT)
Received: from drow by caradoc.them.org with local (Exim 4.69) 	(envelope-from <drow@caradoc.them.org>) 	id 1Jg5xl-0001V3-8S; Sun, 30 Mar 2008 18:25:17 -0400
Date: Sun, 30 Mar 2008 22:25:00 -0000
From: Daniel Jacobowitz <drow@false.org>
To: "Maciej W. Rozycki" <macro@mips.com>
Cc: gdb-patches@sourceware.org, "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: gdb.base/break.exp: Mark failures as such
Message-ID: <20080330222517.GA5747@caradoc.them.org>
Mail-Followup-To: "Maciej W. Rozycki" <macro@mips.com>, 	gdb-patches@sourceware.org, 	"Maciej W. Rozycki" <macro@linux-mips.org>
References: <Pine.LNX.4.61.0803281623570.1324@perivale.mips.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.61.0803281623570.1324@perivale.mips.com>
User-Agent: Mutt/1.5.17 (2007-12-11)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-03/txt/msg00490.txt.bz2

On Fri, Mar 28, 2008 at 04:32:00PM +0000, Maciej W. Rozycki wrote:
> Hello,
> 
>  A few tests in gdb.base/break.exp incorrectly flag their catch-all 
> pattern as a success.  Here is a fix, including some reformatting which 
> actually makes makes them readable (the current opposite state probably 
> being responsible for the problem).
> 
> 2008-03-28  Maciej W. Rozycki  <macro@mips.com>
> 
> 	* gdb.base/break.exp: Mark failures as such.  Fix formatting.
> 
>  Almost obvious, but just in case: OK to apply?

OK.

> +    -re ".*$gdb_prompt $" {
> +	fail "Temporary breakpoint line number #1"
> +    }
> +    timeout {
> +	fail "breakpoint line number #1 (timeout)"
> +    }

Could you fix the test name in the timeout fail, too?


-- 
Daniel Jacobowitz
CodeSourcery