Re: [RFC] solib-svr4.c gdb_byteised.

[Manoj Iyer <manjo@austin.ibm.com>]

Mark,

Any comments? ok to commit?

>
> > > solib-svr4.c compiles without errors on ppc64 with gcc4.0. Here is a
> > > patch...
> > >
> > >
> > > 2005-05-26  Manoj Iyer  <manjo@austin.ibm.com>
> > >
> > > 	* solib-svr4.c: lm_info structure convert type of lm to gdb_byte.
> > > 	(elf_locate_base): Converted types of buf, bufend, pbuf, to gdb_byte.
> > > 	(first_link_map_member): Converted type of r_map_buf to gdb_byte.
> > > 	(open_symbol_file_object): Converted type of l_name_buf to gdb_byte.
> > > 	(svr4_fetch_objfile_link_map): Converted type of l_name_buf to
> > > 	gdb_byte.
> >
> > I think the l_name_buf change is wrong since it *is* supposed to be
> > a (character) string.
>
>
> gcc4.0 complained abt the signedness...
>
> reversing gdb_byte to char for l_name_buf :
>
>
> /opt/gcc-nightly/4.0-20050526/bin/cc -m64 -c -m64  -mminimal-toc  -I.
> -I.././gdb -I.././gdb/config -DLOCALEDIR="\"/usr/local/share/locale\""
> -DHAVE_CONFIG_H -I.././gdb/../include/opcode -I.././gdb/../readline/..
> -I../bfd -I.././gdb/../bfd -I.././gdb/../include -I../intl
> -I.././gdb/../intl  -DMI_OUT=1 -Wimplicit -Wreturn-type -Wcomment
> -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wformat-nonliteral
> -Wunused-label -Wunused-function  solib-svr4.c
> solib-svr4.c: In function ‘open_symbol_file_object’:
> solib-svr4.c:533: warning: pointer targets in passing argument 2 of
> ‘read_memory’ differ in signedness
> solib-svr4.c:537: warning: pointer targets in passing argument 1 of
> ‘extract_unsigned_integer’ differ in signedness
> solib-svr4.c: In function ‘svr4_fetch_objfile_link_map’:
> solib-svr4.c:707: warning: pointer targets in passing argument 2 of
> ‘read_memory’ differ in signedness
> solib-svr4.c:711: warning: pointer targets in passing argument 1 of
> ‘extract_unsigned_integer’ differ in signedness
> Making init.c
>