From: Kevin Buettner <kevinb@redhat.com>
To: "M.M. Kettenis" <m.m.kettenis@alumnus.utwente.nl>
Cc: gdb-patches@sources.redhat.com, Manoj Iyer <manjo@austin.ibm.com>
Subject: Re: [RFC] solib-svr4.c gdb_byteised.
Date: Fri, 03 Jun 2005 21:09:00 -0000 [thread overview]
Message-ID: <20050603140930.06e1960f@ironwood.lan> (raw)
In-Reply-To: <7320928157066569@webhare>
On Thu, 26 May 2005 22:39:30 +0000
"M.M. Kettenis" <m.m.kettenis@alumnus.utwente.nl> wrote:
> Manoj Iyer <manjo@austin.ibm.com> wrote:
>
> >
> > solib-svr4.c compiles without errors on ppc64 with gcc4.0. Here is a
> > patch...
> >
> >
> > 2005-05-26 Manoj Iyer <manjo@austin.ibm.com>
> >
> > * solib-svr4.c: lm_info structure convert type of lm to gdb_byte.
> > (elf_locate_base): Converted types of buf, bufend, pbuf, to gdb_byte.
> > (first_link_map_member): Converted type of r_map_buf to gdb_byte.
> > (open_symbol_file_object): Converted type of l_name_buf to gdb_byte.
> > (svr4_fetch_objfile_link_map): Converted type of l_name_buf to
> > gdb_byte.
>
> I think the l_name_buf change is wrong since it *is* supposed to be
> a (character) string.
Actually, it's the address of a character string. I think Manoj's
change is correct.
Kevin
next prev parent reply other threads:[~2005-06-03 21:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-26 22:50 Manoj Iyer
2005-05-27 4:41 ` M.M. Kettenis
2005-05-27 4:54 ` Manoj Iyer
2005-05-31 16:06 ` Manoj Iyer
2005-06-03 21:09 ` Kevin Buettner [this message]
2005-06-12 0:04 ` Mark Kettenis
2005-06-03 21:14 ` Kevin Buettner
2005-06-06 22:26 ` [PATCH] " Manoj Iyer
2005-06-07 0:07 ` Daniel Jacobowitz
2005-06-07 8:34 ` Manoj Iyer
2005-05-31 20:45 [RFC] " Paul Schlie
2005-05-31 22:22 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050603140930.06e1960f@ironwood.lan \
--to=kevinb@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=m.m.kettenis@alumnus.utwente.nl \
--cc=manjo@austin.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox