From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-39799-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 30818 invoked by alias); 3 Jun 2005 21:09:59 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 30785 invoked by uid 22791); 3 Jun 2005 21:09:53 -0000
Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31)
    by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Fri, 03 Jun 2005 21:09:53 +0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j53L9lg9020279
	for <gdb-patches@sources.redhat.com>; Fri, 3 Jun 2005 17:09:52 -0400
Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j53L9lO24372;
	Fri, 3 Jun 2005 17:09:47 -0400
Received: from localhost.localdomain (vpn50-28.rdu.redhat.com [172.16.50.28])
	by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id j53L9aBU002760;
	Fri, 3 Jun 2005 17:09:46 -0400
Received: from ironwood.lan (ironwood.lan [192.168.64.8])
	by localhost.localdomain (8.12.11/8.12.10) with ESMTP id j53L9U4V005628;
	Fri, 3 Jun 2005 14:09:31 -0700
Date: Fri, 03 Jun 2005 21:09:00 -0000
From: Kevin Buettner <kevinb@redhat.com>
To: "M.M. Kettenis" <m.m.kettenis@alumnus.utwente.nl>
Cc: gdb-patches@sources.redhat.com, Manoj Iyer <manjo@austin.ibm.com>
Subject: Re: [RFC] solib-svr4.c gdb_byteised.
Message-ID: <20050603140930.06e1960f@ironwood.lan>
In-Reply-To: <7320928157066569@webhare>
References: <Pine.LNX.4.58.0505261717060.13210@lazy>
	<7320928157066569@webhare>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-SW-Source: 2005-06/txt/msg00032.txt.bz2

On Thu, 26 May 2005 22:39:30 +0000
"M.M. Kettenis" <m.m.kettenis@alumnus.utwente.nl> wrote:

> Manoj Iyer <manjo@austin.ibm.com> wrote: 
> 
> > 
> > solib-svr4.c compiles without errors on ppc64 with gcc4.0. Here is a
> > patch...
> > 
> > 
> > 2005-05-26  Manoj Iyer  <manjo@austin.ibm.com>
> > 
> > 	* solib-svr4.c: lm_info structure convert type of lm to gdb_byte.
> > 	(elf_locate_base): Converted types of buf, bufend, pbuf, to gdb_byte.
> > 	(first_link_map_member): Converted type of r_map_buf to gdb_byte.
> > 	(open_symbol_file_object): Converted type of l_name_buf to gdb_byte.
> > 	(svr4_fetch_objfile_link_map): Converted type of l_name_buf to
> > 	gdb_byte.
> 
> I think the l_name_buf change is wrong since it *is* supposed to be
> a (character) string.

Actually, it's the address of a character string.  I think Manoj's
change is correct.

Kevin