From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4252 invoked by alias); 31 May 2005 14:42:02 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4184 invoked by uid 22791); 31 May 2005 14:41:51 -0000 Received: from e32.co.us.ibm.com (HELO e32.co.us.ibm.com) (32.97.110.130) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Tue, 31 May 2005 14:41:51 +0000 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e32.co.us.ibm.com (8.12.10/8.12.9) with ESMTP id j4VEfm0c504478 for ; Tue, 31 May 2005 10:41:48 -0400 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay04.boulder.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j4VEfmmm165752 for ; Tue, 31 May 2005 08:41:48 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11/8.13.3) with ESMTP id j4VEfm7W002586 for ; Tue, 31 May 2005 08:41:48 -0600 Received: from austin.ibm.com (netmail2.austin.ibm.com [9.41.248.176]) by d03av02.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j4VEflT0002567; Tue, 31 May 2005 08:41:47 -0600 Received: from lazy.austin.ibm.com (lazy.austin.ibm.com [9.53.94.97]) by austin.ibm.com (8.12.10/8.12.10) with ESMTP id j4VEfk8E136320; Tue, 31 May 2005 09:41:47 -0500 Date: Tue, 31 May 2005 16:06:00 -0000 From: Manoj Iyer X-X-Sender: manjo@lazy To: "M.M. Kettenis" cc: gdb-patches@sources.redhat.com Subject: Re: [RFC] solib-svr4.c gdb_byteised. In-Reply-To: Message-ID: References: <7320928157066569@webhare> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE X-SW-Source: 2005-05/txt/msg00663.txt.bz2 Mark, Any comments? ok to commit? > > > > solib-svr4.c compiles without errors on ppc64 with gcc4.0. Here is a > > > patch... > > > > > > > > > 2005-05-26 Manoj Iyer > > > > > > * solib-svr4.c: lm_info structure convert type of lm to gdb_byte. > > > (elf_locate_base): Converted types of buf, bufend, pbuf, to gdb_byte. > > > (first_link_map_member): Converted type of r_map_buf to gdb_byte. > > > (open_symbol_file_object): Converted type of l_name_buf to gdb_byte. > > > (svr4_fetch_objfile_link_map): Converted type of l_name_buf to > > > gdb_byte. > > > > I think the l_name_buf change is wrong since it *is* supposed to be > > a (character) string. > > > gcc4.0 complained abt the signedness... > > reversing gdb_byte to char for l_name_buf : > > > /opt/gcc-nightly/4.0-20050526/bin/cc -m64 -c -m64 -mminimal-toc -I. > -I.././gdb -I.././gdb/config -DLOCALEDIR=3D"\"/usr/local/share/locale\"" > -DHAVE_CONFIG_H -I.././gdb/../include/opcode -I.././gdb/../readline/.. > -I../bfd -I.././gdb/../bfd -I.././gdb/../include -I../intl > -I.././gdb/../intl -DMI_OUT=3D1 -Wimplicit -Wreturn-type -Wcomment > -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wformat-nonliteral > -Wunused-label -Wunused-function solib-svr4.c > solib-svr4.c: In function =E2=80=98open_symbol_file_object=E2=80=99: > solib-svr4.c:533: warning: pointer targets in passing argument 2 of > =E2=80=98read_memory=E2=80=99 differ in signedness > solib-svr4.c:537: warning: pointer targets in passing argument 1 of > =E2=80=98extract_unsigned_integer=E2=80=99 differ in signedness > solib-svr4.c: In function =E2=80=98svr4_fetch_objfile_link_map=E2=80=99: > solib-svr4.c:707: warning: pointer targets in passing argument 2 of > =E2=80=98read_memory=E2=80=99 differ in signedness > solib-svr4.c:711: warning: pointer targets in passing argument 1 of > =E2=80=98extract_unsigned_integer=E2=80=99 differ in signedness > Making init.c >