Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] scope_breakpoint -> internal breakpoint
Date: Tue, 20 Aug 2002 13:03:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.44.0208201304410.1421-100000@valrhona.uglyboxes.com> (raw)
In-Reply-To: <3D629AB7.2ECE3374@redhat.com>

On Tue, 20 Aug 2002, Michael Snyder wrote:

> Good idea -- approved.

Wow, that was quick. Thanks! I've committed this patch.

Keith
 
> > ChangeLog
> > 2002-08-20  Keith Seitz  <keiths@redhat.com>
> > 
> >         * breakpoints.c (watch_command_1): Use internal breakpoint
> >         when setting a watchpoint_scope breakpoint.
> > 
> > Patch
> > Index: breakpoint.c
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/breakpoint.c,v
> > retrieving revision 1.80
> > diff -p -r1.80 breakpoint.c
> > *** breakpoint.c        17 Aug 2002 06:12:52 -0000      1.80
> > --- breakpoint.c        20 Aug 2002 18:19:42 -0000
> > *************** watch_command_1 (char *arg, int accessfl
> > *** 5331,5346 ****
> >         if (prev_frame)
> >         {
> >           struct breakpoint *scope_breakpoint;
> > !         struct symtab_and_line scope_sal;
> > !
> > !         INIT_SAL (&scope_sal);        /* initialize to zeroes */
> > !         scope_sal.pc = get_frame_pc (prev_frame);
> > !         scope_sal.section = find_pc_overlay (scope_sal.pc);
> > !
> > !         scope_breakpoint = set_raw_breakpoint (scope_sal,
> > !                                                bp_watchpoint_scope);
> > !         set_breakpoint_count (breakpoint_count + 1);
> > !         scope_breakpoint->number = breakpoint_count;
> > 
> >           scope_breakpoint->enable_state = bp_enabled;
> > 
> > --- 5331,5338 ----
> >         if (prev_frame)
> >         {
> >           struct breakpoint *scope_breakpoint;
> > !         scope_breakpoint = create_internal_breakpoint (get_frame_pc (prev_frame),
> > !                                                        bp_watchpoint_scope);
> > 
> >           scope_breakpoint->enable_state = bp_enabled;
> >
> 



      reply	other threads:[~2002-08-20 20:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-20 11:27 Keith Seitz
2002-08-20 12:55 ` Michael Snyder
2002-08-20 13:03   ` Keith Seitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44.0208201304410.1421-100000@valrhona.uglyboxes.com \
    --to=keiths@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox