From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-17863-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 8587 invoked by alias); 20 Aug 2002 20:03:51 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 8578 invoked from network); 20 Aug 2002 20:03:51 -0000
Received: from unknown (HELO valrhona.uglyboxes.com) (64.1.192.220)
  by sources.redhat.com with SMTP; 20 Aug 2002 20:03:51 -0000
Received: from localhost.localdomain (IDENT:ihJPECOKL3TCuH/FtXyR2BQsBUDla1ww@localhost.localdomain [127.0.0.1])
	by valrhona.uglyboxes.com (8.11.6/8.11.6) with ESMTP id g7KK6GL13336
	for <gdb-patches@sources.redhat.com>; Tue, 20 Aug 2002 13:06:32 -0700
Date: Tue, 20 Aug 2002 13:03:00 -0000
From: Keith Seitz <keiths@redhat.com>
X-X-Sender: keiths@valrhona.uglyboxes.com
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] scope_breakpoint -> internal breakpoint
In-Reply-To: <3D629AB7.2ECE3374@redhat.com>
Message-ID: <Pine.LNX.4.44.0208201304410.1421-100000@valrhona.uglyboxes.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-SW-Source: 2002-08/txt/msg00613.txt.bz2

On Tue, 20 Aug 2002, Michael Snyder wrote:

> Good idea -- approved.

Wow, that was quick. Thanks! I've committed this patch.

Keith
 
> > ChangeLog
> > 2002-08-20  Keith Seitz  <keiths@redhat.com>
> > 
> >         * breakpoints.c (watch_command_1): Use internal breakpoint
> >         when setting a watchpoint_scope breakpoint.
> > 
> > Patch
> > Index: breakpoint.c
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/breakpoint.c,v
> > retrieving revision 1.80
> > diff -p -r1.80 breakpoint.c
> > *** breakpoint.c        17 Aug 2002 06:12:52 -0000      1.80
> > --- breakpoint.c        20 Aug 2002 18:19:42 -0000
> > *************** watch_command_1 (char *arg, int accessfl
> > *** 5331,5346 ****
> >         if (prev_frame)
> >         {
> >           struct breakpoint *scope_breakpoint;
> > !         struct symtab_and_line scope_sal;
> > !
> > !         INIT_SAL (&scope_sal);        /* initialize to zeroes */
> > !         scope_sal.pc = get_frame_pc (prev_frame);
> > !         scope_sal.section = find_pc_overlay (scope_sal.pc);
> > !
> > !         scope_breakpoint = set_raw_breakpoint (scope_sal,
> > !                                                bp_watchpoint_scope);
> > !         set_breakpoint_count (breakpoint_count + 1);
> > !         scope_breakpoint->number = breakpoint_count;
> > 
> >           scope_breakpoint->enable_state = bp_enabled;
> > 
> > --- 5331,5338 ----
> >         if (prev_frame)
> >         {
> >           struct breakpoint *scope_breakpoint;
> > !         scope_breakpoint = create_internal_breakpoint (get_frame_pc (prev_frame),
> > !                                                        bp_watchpoint_scope);
> > 
> >           scope_breakpoint->enable_state = bp_enabled;
> >
>