[PATCH] dejagnu lib/framework.exp PRMS pattern

[PATCH] dejagnu lib/framework.exp PRMS pattern

[Jimmy Guo]

This patch is to relax the pattern for a PRMS id to allow a more general
form of bug ID as part of setup_xfail call.

Today, only an all-digit form of bug ID is accepted.  For HP testing, we
want to capture HP bug tracking IDs in the form of alphanumerics.
This patch can be viewed as HP-specific.  If so I'm also happy with
keeping this chance HP local -- just something on the table for the
maintainer to evaluate its general usefulness ... if it doesn't hurt,
I'd like to see it in the repository though, which would make it easier
to share tests between HP and non-HP developers (without need to chop
things off setup_xfail calls).

- Jimmy

Tue Aug  1 11:09:39	Jimmy Guo	<guo@cup.hp.com>

	* lib/framework.exp (setup_xfail): Relax PRMS string pattern
	to allow a more general bug ID specification (without '-').

Index: lib/framework.exp
/usr/local/bin/diff -c -L lib/framework.exp lib/framework.exp@@/main/cygnus/5 lib/framework.exp
*** lib/framework.exp
--- lib/framework.exp	Tue Aug  1 11:09:03 2000
***************
*** 417,424 ****
  # Setup a flag to control whether a failure is expected or not
  #
  # Multiple target triplet patterns can be specified for targets
! # for which the test fails.  A decimal number can be specified,
! # which is the PRMS number.
  #
  proc setup_xfail { args } {
      global xfail_flag
--- 417,424 ----
  # Setup a flag to control whether a failure is expected or not
  #
  # Multiple target triplet patterns can be specified for targets
! # for which the test fails.  A bug report ID can be specified,
! # which is a string without '-'.
  #
  proc setup_xfail { args } {
      global xfail_flag
***************
*** 428,435 ****
      set argc [ llength $args ]
      for { set i 0 } { $i < $argc } { incr i } {
  	set sub_arg [ lindex $args $i ]
! 	# is a prms number. we assume this is a number with no characters
! 	if [regexp "^\[0-9\]+$" $sub_arg] { 
  	    set xfail_prms $sub_arg
  	    continue
  	}
--- 428,435 ----
      set argc [ llength $args ]
      for { set i 0 } { $i < $argc } { incr i } {
  	set sub_arg [ lindex $args $i ]
! 	# is a prms number. we assume this is a string with no '-' characters
! 	if [regexp "^\[^\-\]+$" $sub_arg] { 
  	    set xfail_prms $sub_arg
  	    continue
  	}

Re: [PATCH] dejagnu lib/framework.exp PRMS pattern

[Jimmy Guo]

FYI I've committed the patch.

- Jimmy Guo

On Tue, 1 Aug 2000, Jimmy Guo wrote:

>This patch is to relax the pattern for a PRMS id to allow a more general
>form of bug ID as part of setup_xfail call.
>
>Today, only an all-digit form of bug ID is accepted.  For HP testing, we
>want to capture HP bug tracking IDs in the form of alphanumerics.
>This patch can be viewed as HP-specific.  If so I'm also happy with
>keeping this chance HP local -- just something on the table for the
>maintainer to evaluate its general usefulness ... if it doesn't hurt,
>I'd like to see it in the repository though, which would make it easier
>to share tests between HP and non-HP developers (without need to chop
>things off setup_xfail calls).
>
>- Jimmy
>
>Tue Aug  1 11:09:39	Jimmy Guo	<guo@cup.hp.com>
>
>	* lib/framework.exp (setup_xfail): Relax PRMS string pattern
>	to allow a more general bug ID specification (without '-').
>
>Index: lib/framework.exp
>/usr/local/bin/diff -c -L lib/framework.exp lib/framework.exp@@/main/cygnus/5 lib/framework.exp
>*** lib/framework.exp
>--- lib/framework.exp	Tue Aug  1 11:09:03 2000
>***************
>*** 417,424 ****
>  # Setup a flag to control whether a failure is expected or not
>  #
>  # Multiple target triplet patterns can be specified for targets
>! # for which the test fails.  A decimal number can be specified,
>! # which is the PRMS number.
>  #
>  proc setup_xfail { args } {
>      global xfail_flag
>--- 417,424 ----
>  # Setup a flag to control whether a failure is expected or not
>  #
>  # Multiple target triplet patterns can be specified for targets
>! # for which the test fails.  A bug report ID can be specified,
>! # which is a string without '-'.
>  #
>  proc setup_xfail { args } {
>      global xfail_flag
>***************
>*** 428,435 ****
>      set argc [ llength $args ]
>      for { set i 0 } { $i < $argc } { incr i } {
>  	set sub_arg [ lindex $args $i ]
>! 	# is a prms number. we assume this is a number with no characters
>! 	if [regexp "^\[0-9\]+$" $sub_arg] { 
>  	    set xfail_prms $sub_arg
>  	    continue
>  	}
>--- 428,435 ----
>      set argc [ llength $args ]
>      for { set i 0 } { $i < $argc } { incr i } {
>  	set sub_arg [ lindex $args $i ]
>! 	# is a prms number. we assume this is a string with no '-' characters
>! 	if [regexp "^\[^\-\]+$" $sub_arg] { 
>  	    set xfail_prms $sub_arg
>  	    continue
>  	}
>
>