Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jimmy Guo <guo@cup.hp.com>
To: gdb-patches@sourceware.cygnus.com
Subject: [PATCH] dejagnu lib/framework.exp PRMS pattern
Date: Tue, 01 Aug 2000 11:19:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.10.10008011111140.6905-100000@hpcll168.cup.hp.com> (raw)

This patch is to relax the pattern for a PRMS id to allow a more general
form of bug ID as part of setup_xfail call.

Today, only an all-digit form of bug ID is accepted.  For HP testing, we
want to capture HP bug tracking IDs in the form of alphanumerics.
This patch can be viewed as HP-specific.  If so I'm also happy with
keeping this chance HP local -- just something on the table for the
maintainer to evaluate its general usefulness ... if it doesn't hurt,
I'd like to see it in the repository though, which would make it easier
to share tests between HP and non-HP developers (without need to chop
things off setup_xfail calls).

- Jimmy

Tue Aug  1 11:09:39	Jimmy Guo	<guo@cup.hp.com>

	* lib/framework.exp (setup_xfail): Relax PRMS string pattern
	to allow a more general bug ID specification (without '-').

Index: lib/framework.exp
/usr/local/bin/diff -c -L lib/framework.exp lib/framework.exp@@/main/cygnus/5 lib/framework.exp
*** lib/framework.exp
--- lib/framework.exp	Tue Aug  1 11:09:03 2000
***************
*** 417,424 ****
  # Setup a flag to control whether a failure is expected or not
  #
  # Multiple target triplet patterns can be specified for targets
! # for which the test fails.  A decimal number can be specified,
! # which is the PRMS number.
  #
  proc setup_xfail { args } {
      global xfail_flag
--- 417,424 ----
  # Setup a flag to control whether a failure is expected or not
  #
  # Multiple target triplet patterns can be specified for targets
! # for which the test fails.  A bug report ID can be specified,
! # which is a string without '-'.
  #
  proc setup_xfail { args } {
      global xfail_flag
***************
*** 428,435 ****
      set argc [ llength $args ]
      for { set i 0 } { $i < $argc } { incr i } {
  	set sub_arg [ lindex $args $i ]
! 	# is a prms number. we assume this is a number with no characters
! 	if [regexp "^\[0-9\]+$" $sub_arg] { 
  	    set xfail_prms $sub_arg
  	    continue
  	}
--- 428,435 ----
      set argc [ llength $args ]
      for { set i 0 } { $i < $argc } { incr i } {
  	set sub_arg [ lindex $args $i ]
! 	# is a prms number. we assume this is a string with no '-' characters
! 	if [regexp "^\[^\-\]+$" $sub_arg] { 
  	    set xfail_prms $sub_arg
  	    continue
  	}


             reply	other threads:[~2000-08-01 11:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-08-01 11:19 Jimmy Guo [this message]
2000-08-02 15:39 ` Jimmy Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.10.10008011111140.6905-100000@hpcll168.cup.hp.com \
    --to=guo@cup.hp.com \
    --cc=gdb-patches@sourceware.cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox