From: Hans-Peter Nilsson <hp@bitrange.com>
To: Ben Elliston <bje@au1.ibm.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH: More ISO-ifying of sim/common
Date: Sat, 09 Jul 2005 05:51:00 -0000 [thread overview]
Message-ID: <Pine.BSF.4.58.0507090147560.33069@dair.pair.com> (raw)
In-Reply-To: <42CE3031.1010907@au.ibm.com>
Hi Ben.
On Fri, 8 Jul 2005, Ben Elliston wrote:
> Index: sim-load.c
> @@ -196,17 +186,11 @@ xprintf VPARAMS ((host_callback *callbac
> static void
> eprintf VPARAMS ((host_callback *callback, const char *fmt, ...))
> {
> -#ifndef ANSI_PROTOTYPES
> host_callback *callback;
> char *fmt;
> -#endif
> va_list ap;
>
> VA_START (ap, fmt);
> -#ifndef ANSI_PROTOTYPES
> - callback = va_arg (ap, host_callback *);
> - fmt = va_arg (ap, char *);
> -#endif
The first should have been like the second. This breaks build
with gcc-4. (But not with e.g. gcc-3.3 for some uninteresting
reason.)
brgds, H-P
prev parent reply other threads:[~2005-07-09 5:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-08 8:18 Ben Elliston
2005-07-09 5:51 ` Hans-Peter Nilsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.BSF.4.58.0507090147560.33069@dair.pair.com \
--to=hp@bitrange.com \
--cc=bje@au1.ibm.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox