Re: PATCH: More ISO-ifying of sim/common

Hans-Peter Nilsson
2005-07-09T05:51:44Z

Hi Ben.

On Fri, 8 Jul 2005, Ben Elliston wrote:
> Index: sim-load.c

> @@ -196,17 +186,11 @@ xprintf VPARAMS ((host_callback *callbac
> static void
> eprintf VPARAMS ((host_callback *callback, const char *fmt, ...))
> {
> -#ifndef ANSI_PROTOTYPES
> host_callback *callback;
> char *fmt;
> -#endif
> va_list ap;
>
> VA_START (ap, fmt);
> -#ifndef ANSI_PROTOTYPES
> - callback = va_arg (ap, host_callback *);
> - fmt = va_arg (ap, char *);
> -#endif

The first should have been like the second. This breaks build
with gcc-4. (But not with e.g. gcc-3.3 for some uninteresting
reason.)

brgds, H-P