From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-40250-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 6822 invoked by alias); 9 Jul 2005 05:51:44 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 6814 invoked by uid 22791); 9 Jul 2005 05:51:40 -0000
Received: from dair.pair.com (HELO dair.pair.com) (209.68.1.49)
    by sourceware.org (qpsmtpd/0.30-dev) with SMTP; Sat, 09 Jul 2005 05:51:40 +0000
Received: (qmail 35185 invoked by uid 20157); 9 Jul 2005 05:51:38 -0000
Date: Sat, 09 Jul 2005 05:51:00 -0000
From: Hans-Peter Nilsson <hp@bitrange.com>
X-X-Sender: hp@dair.pair.com
To: Ben Elliston <bje@au1.ibm.com>
cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH: More ISO-ifying of sim/common
In-Reply-To: <42CE3031.1010907@au.ibm.com>
Message-ID: <Pine.BSF.4.58.0507090147560.33069@dair.pair.com>
References: <42CE3031.1010907@au.ibm.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-SW-Source: 2005-07/txt/msg00088.txt.bz2

Hi Ben.

On Fri, 8 Jul 2005, Ben Elliston wrote:
> Index: sim-load.c

> @@ -196,17 +186,11 @@ xprintf VPARAMS ((host_callback *callbac
>  static void
>  eprintf VPARAMS ((host_callback *callback, const char *fmt, ...))
>  {
> -#ifndef ANSI_PROTOTYPES
>    host_callback *callback;
>    char *fmt;
> -#endif
>    va_list ap;
>
>    VA_START (ap, fmt);
> -#ifndef ANSI_PROTOTYPES
> -  callback = va_arg (ap, host_callback *);
> -  fmt = va_arg (ap, char *);
> -#endif

The first should have been like the second.  This breaks build
with gcc-4.  (But not with e.g. gcc-3.3 for some uninteresting
reason.)

brgds, H-P