From: Francois Rigault <francois.rigault@amadeus.com>
To: gdb-patches@sourceware.org
Subject: [Patch] Improve path lookup of absolute source file
Date: Thu, 11 Sep 2008 12:48:00 -0000 [thread overview]
Message-ID: <OF93DA0F60.81E48D43-ONC12574C1.00378C52-C12574C1.00463B4A@amadeus.com> (raw)
When setting breakpoints on a source file using an absolute path,
lookup_symtab will try to match the target source file path with each
symbol file path. For each of these paths, the realpath function is
called, potentially leading to a big number of IOs.
On a slow IO filesystem, like a network file system, this can slow down
the performances. gdb takes here 15s to complete the setting of the
first breakpoint on an absolute source file path.
In order to let gdb find the files without generating IOs, a simple
trick is to check that symbol source file and target source file have
the same basename, as source file used at compilation time and the one
used for debugging are unlikely to have different basenames. See the
patch below against gdb-6.8.
Regards
*** gdb/symtab.c Thu Sep 11 11:10:13 2008
--- gdb/symtab.c Thu Sep 11 11:31:46 2008
*************** lookup_partial_symtab (const char *name)
*** 259,264 ****
--- 259,270 ----
return (pst);
}
+ /* Skip this symbol if basenames differ. */
+ if (FILENAME_CMP (lbasename(name), lbasename(pst->filename)) != 0)
+ {
+ continue;
+ }
+
/* If the user gave us an absolute path, try to find the file in
this symtab and use its absolute path. */
if (full_path != NULL)
next reply other threads:[~2008-09-11 12:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-11 12:48 Francois Rigault [this message]
2008-09-26 4:15 ` Thiago Jung Bauermann
2008-09-26 13:02 ` Daniel Jacobowitz
2009-03-11 10:32 Francois Rigault
2009-03-15 19:44 ` Joel Brobecker
2009-03-17 15:57 ` Francois Rigault
2009-04-24 14:52 ` Tom Tromey
2009-04-24 15:12 ` Eli Zaretskii
2009-07-15 17:16 Francois Rigault
2009-07-30 0:07 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OF93DA0F60.81E48D43-ONC12574C1.00378C52-C12574C1.00463B4A@amadeus.com \
--to=francois.rigault@amadeus.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox