Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Francois Rigault <francois.rigault@amadeus.com>
Cc: Daniel Jacobowitz <drow@false.org>,
		Thiago Jung Bauermann <thiago.bauermann@gmail.com>,
		gdb-patches@sourceware.org
Subject: Re: [Patch] Improve path lookup of absolute source file
Date: Sun, 15 Mar 2009 19:44:00 -0000	[thread overview]
Message-ID: <20090315193005.GA9294@adacore.com> (raw)
In-Reply-To: <OFD9AE0868.9D61C83E-ONC1257576.002EC255-C1257576.002EE478@amadeus.com>

> would you accept a patch that uses a macro somewhere so that users can
> choose to compile gdb with or without the modified lookup routine ? 

Not sure what the other maintainers think, but for the type of change
that you're suggestion, we generally don't. This tends to complicate
the code, and can also confuse uses as to why the same version of GDB
would "work" in one case and "not work" in the other. There's also
the question of testing if your change is disabled by default.

A softer approach would be based on using a "set ..." command to
determine one approach or the other. But I am not sure it would make
sense in this case, as my understanding is that the setting would
allow the user to switch between two approaches that are similar,
but with different holes in them.

-- 
Joel


  reply	other threads:[~2009-03-15 19:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-11 10:32 Francois Rigault
2009-03-15 19:44 ` Joel Brobecker [this message]
2009-03-17 15:57   ` Francois Rigault
2009-04-24 14:52     ` Tom Tromey
2009-04-24 15:12       ` Eli Zaretskii
  -- strict thread matches above, loose matches on Subject: below --
2009-07-15 17:16 Francois Rigault
2009-07-30  0:07 ` Tom Tromey
2008-09-11 12:48 Francois Rigault
2008-09-26  4:15 ` Thiago Jung Bauermann
2008-09-26 13:02 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090315193005.GA9294@adacore.com \
    --to=brobecker@adacore.com \
    --cc=drow@false.org \
    --cc=francois.rigault@amadeus.com \
    --cc=gdb-patches@sourceware.org \
    --cc=thiago.bauermann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox