From: Daniel Jacobowitz <drow@false.org>
To: Francois Rigault <francois.rigault@amadeus.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [Patch] Improve path lookup of absolute source file
Date: Fri, 26 Sep 2008 13:02:00 -0000 [thread overview]
Message-ID: <20080926130155.GE21287@caradoc.them.org> (raw)
In-Reply-To: <OF93DA0F60.81E48D43-ONC12574C1.00378C52-C12574C1.00463B4A@amadeus.com>
On Thu, Sep 11, 2008 at 02:47:09PM +0200, Francois Rigault wrote:
> In order to let gdb find the files without generating IOs, a simple
> trick is to check that symbol source file and target source file have
> the same basename, as source file used at compilation time and the one
> used for debugging are unlikely to have different basenames. See the
> patch below against gdb-6.8.
I'm nervous about "unlikely". What happens before and after if they
do have different basenames? e.g. a symlink foo.c to foo_x86.c; if
GDB or GCC resolves the symlink at some point we'll mismatch and now
completely fail to locate the file.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-09-26 13:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-11 12:48 Francois Rigault
2008-09-26 4:15 ` Thiago Jung Bauermann
2008-09-26 13:02 ` Daniel Jacobowitz [this message]
2009-03-11 10:32 Francois Rigault
2009-03-15 19:44 ` Joel Brobecker
2009-03-17 15:57 ` Francois Rigault
2009-04-24 14:52 ` Tom Tromey
2009-04-24 15:12 ` Eli Zaretskii
2009-07-15 17:16 Francois Rigault
2009-07-30 0:07 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080926130155.GE21287@caradoc.them.org \
--to=drow@false.org \
--cc=francois.rigault@amadeus.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox