Re: [PATCH 2/2] gdb: Tab complete internalvars in expressions

[nt8r@protonmail.com]

Thanks for the enthusiasm! I'm adding some tests in v2.

How do I go about copyright assignment? The documents I'm seeing seem to suggest getting in touch with a maintainer over e-mail.

Thanks,
Antonio

On Monday, August 26th, 2024 at 4:54 PM, Keith Seitz <keiths@redhat.com> wrote:

> Hi,
> 
> On 8/22/24 12:41 PM, nt8r@protonmail.com wrote:
> 
> > It seems I misunderstood the semantics of the 'word' and 'text' parameters here. I'll correct in v2; as written this doesn't work for completions not at the start of the text to complete (e.g. 'print 4+$fo<tab>' or 'print $fo<tab>+4').
> 
> 
> Wow, thank you for taking a look at this! This is a most welcome
> submission.
> 
> Is it possible to include any tests exercising this new feature? That
> would make review much easier for us.
> 
> There are several examples in gdb/testsuite/ to follow. Grep
> for "test_gdb_complete" or take a look at the support routines
> in gdb/testsuite/lib/completion-support.exp. [Also see
> https://sourceware.org/gdb/wiki/GDBTestcaseCookbook and
> gdb/testsuite/README for add'l pointers/examples on writing
> and running tests.]
> 
> Do you have an assignment on file? If not, in order for us to
> accept your patch, please see/follow
> 
> https://sourceware.org/gdb/wiki/ContributionChecklist#FSF_copyright_Assignment
> 
> Thank you again for submitting a patch to fix this.
> 
> Keith