From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id x29QAj9/zmbSzRYAWB0awg (envelope-from ) for ; Tue, 27 Aug 2024 21:37:03 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=protonmail.com header.i=@protonmail.com header.a=rsa-sha256 header.s=protonmail3 header.b=Qu9LFDIw; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D3A741E0D0; Tue, 27 Aug 2024 21:37:02 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 73F8C1E030 for ; Tue, 27 Aug 2024 21:37:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D0ABC385ED4B for ; Wed, 28 Aug 2024 01:36:58 +0000 (GMT) Received: from mail-43166.protonmail.ch (mail-43166.protonmail.ch [185.70.43.166]) by sourceware.org (Postfix) with ESMTPS id 972133858C66 for ; Wed, 28 Aug 2024 01:36:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 972133858C66 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=protonmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 972133858C66 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=185.70.43.166 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724808998; cv=none; b=lM0GJrJkbeGAi2lLIpEWNSXXM15/mMIaULkK+AUDjMqtw3GVZOj+t8w8u2CbW2HLbnVZoSZCC2MQE+lg7DThygHpKPUeQEtJhcmRp3tqagwaUCmdGSGZBA9mXsNGIPebRqh6VUVvLhuPOQZwA3PA57YH3N/JeuTcDkLTNAWhIDU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724808998; c=relaxed/simple; bh=SZbSmY/FdJIhp5tdYdjXDN3N8KpdUmYsiOIl7EyhNa8=; h=DKIM-Signature:Date:To:From:Subject:Message-ID:MIME-Version; b=r5Zxwug+4+0zNgZlrXGN4vC/cci/GAk24VjDyGp4mRCNZ+Nv8JOzSAlVu/0/kOGsNhiQ7fO2HErtg7ydRA+FvVwP5KmjuwKsXk5SgmJlGICEucdPjO/FVFhaBUaUTxlJmRv5E3ZySsy7ZqWOF+PgGKPmxNcTjUvyeIBFamYiL5U= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1724808993; x=1725068193; bh=SZbSmY/FdJIhp5tdYdjXDN3N8KpdUmYsiOIl7EyhNa8=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=Qu9LFDIwxWbczsMj8d5Ei9QKJvcj8OowdUnx10742mbRrfZvQt1VIxLKsk/9L77eP vG07ANZH+t2xJIlWMqzO6MXe20PNoyO0NLBGfgXPb9RovZG9cu7zp+M3+2xIrEqxeM 6X0ZnzS/tdLkWiHKuSqLyZNO68CEa6mkZLbq/wTxKXRGoiZ+g3XEu2742TUJcT0ktb qj64liOXfhk/ofGh8LrMeCu9Qw8Leapvw/sRWCA8zmJmWOdP8Buq8N2lgoqoj+VHkQ 4s6Vz9VWENsq9Lq90ULYNGj4NtlFY3ez/WvaqMnYb6K/ctxrJaaoRkTpBtCVBqAvny U1MMCwmG1BPGw== Date: Wed, 28 Aug 2024 01:36:28 +0000 To: Keith Seitz From: nt8r@protonmail.com Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] gdb: Tab complete internalvars in expressions Message-ID: In-Reply-To: <2ebaeed9-d91d-4fbb-98a5-5fb8462c92cc@redhat.com> References: <20240822154730.1595141-1-nt8r@protonmail.com> <20240822154730.1595141-3-nt8r@protonmail.com> <2ebaeed9-d91d-4fbb-98a5-5fb8462c92cc@redhat.com> Feedback-ID: 21706885:user:proton X-Pm-Message-ID: dfafb815be6807b19e40466e988a605c66470803 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Thanks for the enthusiasm! I'm adding some tests in v2. How do I go about copyright assignment? The documents I'm seeing seem to su= ggest getting in touch with a maintainer over e-mail. Thanks, Antonio On Monday, August 26th, 2024 at 4:54 PM, Keith Seitz wr= ote: > Hi, >=20 > On 8/22/24 12:41 PM, nt8r@protonmail.com wrote: >=20 > > It seems I misunderstood the semantics of the 'word' and 'text' paramet= ers here. I'll correct in v2; as written this doesn't work for completions = not at the start of the text to complete (e.g. 'print 4+$fo' or 'print= $fo+4'). >=20 >=20 > Wow, thank you for taking a look at this! This is a most welcome > submission. >=20 > Is it possible to include any tests exercising this new feature? That > would make review much easier for us. >=20 > There are several examples in gdb/testsuite/ to follow. Grep > for "test_gdb_complete" or take a look at the support routines > in gdb/testsuite/lib/completion-support.exp. [Also see > https://sourceware.org/gdb/wiki/GDBTestcaseCookbook and > gdb/testsuite/README for add'l pointers/examples on writing > and running tests.] >=20 > Do you have an assignment on file? If not, in order for us to > accept your patch, please see/follow >=20 > https://sourceware.org/gdb/wiki/ContributionChecklist#FSF_copyright_Assig= nment >=20 > Thank you again for submitting a patch to fix this. >=20 > Keith