From: Keith Seitz <keiths@redhat.com>
To: nt8r@protonmail.com, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdb: Tab complete internalvars in expressions
Date: Mon, 26 Aug 2024 09:54:50 -0700 [thread overview]
Message-ID: <2ebaeed9-d91d-4fbb-98a5-5fb8462c92cc@redhat.com> (raw)
In-Reply-To: <HyPJwVQbdCLo33x_-05gx1LWSHB68L3MSuMrhIPz_O8Ljt_qKneJACuclrKcoH8B7Hhv0JEix2h-XWPgU8w5OEFFKI7RppLmZUU_dlQR86Y=@protonmail.com>
Hi,
On 8/22/24 12:41 PM, nt8r@protonmail.com wrote:
> It seems I misunderstood the semantics of the 'word' and 'text' parameters here. I'll correct in v2; as written this doesn't work for completions not at the start of the text to complete (e.g. 'print 4+$fo<tab>' or 'print $fo<tab>+4').
Wow, thank you for taking a look at this! This is a most welcome
submission.
Is it possible to include any tests exercising this new feature? That
would make review much easier for us.
There are several examples in gdb/testsuite/ to follow. Grep
for "test_gdb_complete" or take a look at the support routines
in gdb/testsuite/lib/completion-support.exp. [Also see
https://sourceware.org/gdb/wiki/GDBTestcaseCookbook and
gdb/testsuite/README for add'l pointers/examples on writing
and running tests.]
Do you have an assignment on file? If not, in order for us to
accept your patch, please see/follow
https://sourceware.org/gdb/wiki/ContributionChecklist#FSF_copyright_Assignment
Thank you again for submitting a patch to fix this.
Keith
next prev parent reply other threads:[~2024-08-26 16:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 15:47 [PATCH 0/2] Tab complete convenience variables Antonio Rische
2024-08-22 15:47 ` [PATCH 1/2] gdb: Do not create variables when parsing expressions Antonio Rische
2024-08-22 15:47 ` [PATCH 2/2] gdb: Tab complete internalvars in expressions Antonio Rische
2024-08-22 19:41 ` nt8r
2024-08-26 16:54 ` Keith Seitz [this message]
2024-08-28 1:36 ` nt8r
2024-08-28 2:30 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ebaeed9-d91d-4fbb-98a5-5fb8462c92cc@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=nt8r@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox