From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id heoSK3azzGZrTRUAWB0awg (envelope-from ) for ; Mon, 26 Aug 2024 12:55:18 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=U5HykXMV; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9DCCB1E0D0; Mon, 26 Aug 2024 12:55:18 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 82D661E08C for ; Mon, 26 Aug 2024 12:55:16 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D24A4385DDDA for ; Mon, 26 Aug 2024 16:55:15 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id CCD653858D26 for ; Mon, 26 Aug 2024 16:54:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CCD653858D26 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CCD653858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724691296; cv=none; b=fotnV07ErjNENQpQwSHUH/gPeQo1dAR1EGjVeXsnE3khzNN0jHPg9DS/AQ8SghVblosgLXs34UPXVPCmXzXmZbHBAqBpPPeYclp/xMpKLce6WXEyhSKccoh8X1B1BM5r4BfDuvSWlRglD72z7QWcH6ASAl/80XpUKAz471aE0dc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724691296; c=relaxed/simple; bh=03DYMggC3NzNwrmXsN06vYyEakK8eIp16In4reBp68g=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=jPww38BlGMP/glQBmTFg/hSKsWq1UmIu/nn4swFawlzTorynP5gM0bDhVH06MXYEFUUV1DJkeb9h+tBHCQKVE2qIpYls+ICVMWIUyL5FX9q2HMAj/eno2DUby7PV9rEJdrAveKS+tzujab9UidoCXJ6BfI/3fBMTNvPZtHcYgzY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724691294; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=03DYMggC3NzNwrmXsN06vYyEakK8eIp16In4reBp68g=; b=U5HykXMV3lBggoGlnCyZrAix5YxxltUSZJpWfP+MosvljeZXt5sFVpc0QY/LNiCEV53GAH eOO1L50/KwBW8LTHKeLL0WVrfX/IgYQy+5YMstTBhj8JJbfUOR+M9/AXQMeRhrf0GHRDHI yDjoRvApkhDFD+1m5OW5/++IxVfB9cs= Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-9-JsV-D_05OZCpRUH4mXd2uA-1; Mon, 26 Aug 2024 12:54:53 -0400 X-MC-Unique: JsV-D_05OZCpRUH4mXd2uA-1 Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-7125fb17a83so2863648b3a.3 for ; Mon, 26 Aug 2024 09:54:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724691292; x=1725296092; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=03DYMggC3NzNwrmXsN06vYyEakK8eIp16In4reBp68g=; b=QJC5bzmlX3pekSsHfvsFIiAashfpN3nK4oq/ghHmLNGM4sioqIOKpzN2T+zLx6nh4p 5Rf+IOi/hTYpKgmuW+Fm39DkDZZKf3+OUMCZUqFIUpn7GvsAkvO4kQSK43ANhmoevQMc X67spvUZZnjnCakZ4uZSTKWrJ2ZDIF0AXa9iWOaJiZsedsvnZ3qV/SVOGVYrMTh+c00e 1r+0vzjLOEF3CaYQodVDTHQO46nqy7CLDKzVsadADnQp8w3MCwVCTpHM3XiQFcIBYV+V IePpHPruPcCLJTgCANFgGkE+A1S19oE1vcPetrN/IxIVPI8SnfKmAjokQ4/QrxfB1LW8 jr/g== X-Forwarded-Encrypted: i=1; AJvYcCVrAFUegK8liLcDtVoTToZx66EYaKXFCcqWJYZ8oBwpojCk4B7KvhPSfRriLpvFb2lNpa9Ru0lXi0RJIg==@sourceware.org X-Gm-Message-State: AOJu0Yzkbs3TfuHKRKKPdf7sv3cLUeOm9jsYhpFq4boKImsI6FfWYlec HPE3/5Ij4Yn46Bv2Re+C2gwRnbtdAMxW14C1/OgsrhBBvyzqtZIiLGRzSNS/wJqQhyfjQvkz4kt Iqhb3BVx/B6pDd/ITovNkEQfXDmiqr63R+D9rqIXzFcnxjFS0+0Qijdh7mBb7u8gT2+I= X-Received: by 2002:a05:6a00:3c8b:b0:70a:f65e:b13d with SMTP id d2e1a72fcca58-71445e73722mr11813618b3a.27.1724691292146; Mon, 26 Aug 2024 09:54:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHacaF6aOv4rhPWKNJNQESxCptyN1mt3ayGN/GvJuh7xfgtQC9TuiiTq7ki9uzGbSDrMPQmMw== X-Received: by 2002:a05:6a00:3c8b:b0:70a:f65e:b13d with SMTP id d2e1a72fcca58-71445e73722mr11813590b3a.27.1724691291622; Mon, 26 Aug 2024 09:54:51 -0700 (PDT) Received: from [150.1.200.127] (174-21-139-113.tukw.qwest.net. [174.21.139.113]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71434315b02sm7216624b3a.152.2024.08.26.09.54.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Aug 2024 09:54:51 -0700 (PDT) Message-ID: <2ebaeed9-d91d-4fbb-98a5-5fb8462c92cc@redhat.com> Date: Mon, 26 Aug 2024 09:54:50 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] gdb: Tab complete internalvars in expressions To: nt8r@protonmail.com, gdb-patches@sourceware.org References: <20240822154730.1595141-1-nt8r@protonmail.com> <20240822154730.1595141-3-nt8r@protonmail.com> From: Keith Seitz In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi, On 8/22/24 12:41 PM, nt8r@protonmail.com wrote: > It seems I misunderstood the semantics of the 'word' and 'text' parameters here. I'll correct in v2; as written this doesn't work for completions not at the start of the text to complete (e.g. 'print 4+$fo' or 'print $fo+4'). Wow, thank you for taking a look at this! This is a most welcome submission. Is it possible to include any tests exercising this new feature? That would make review much easier for us. There are several examples in gdb/testsuite/ to follow. Grep for "test_gdb_complete" or take a look at the support routines in gdb/testsuite/lib/completion-support.exp. [Also see https://sourceware.org/gdb/wiki/GDBTestcaseCookbook and gdb/testsuite/README for add'l pointers/examples on writing and running tests.] Do you have an assignment on file? If not, in order for us to accept your patch, please see/follow https://sourceware.org/gdb/wiki/ContributionChecklist#FSF_copyright_Assignment Thank you again for submitting a patch to fix this. Keith