[patch] Make test messages unique in checkpoint.exp

[patch] Make test messages unique in checkpoint.exp

[Abid, Hafiz]

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

Hi,
While looking at the checkpoint.exp, I noted that there were many tests with same messages. I updated the messages so that they are unique following the convention already used in the file. How does it look?

Regards,
Abid

gdb/testsuite:

2013-01-17  Hafiz Abid Qadeer  <abidh@codesourcery.com>

	* gdb.base/checkpoint.exp: Update test messages to make them unique.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: checkpoint.patch --]
[-- Type: text/x-patch; name="checkpoint.patch", Size: 2578 bytes --]

diff --git a/gdb/testsuite/gdb.base/checkpoint.exp b/gdb/testsuite/gdb.base/checkpoint.exp
index f3366ee..d9c28e0 100644
--- a/gdb/testsuite/gdb.base/checkpoint.exp
+++ b/gdb/testsuite/gdb.base/checkpoint.exp
@@ -230,39 +230,39 @@ gdb_test "restart 1" "if .c == EOF.*" "restart 1 three"
 gdb_test "continue" "breakpoint 2.*" "break2 1 one"
 gdb_test "print ftell (out) > 100000" " = 1.*" "outfile still open 1"
 
-gdb_test "restart 2" "if .c == EOF.*" "restart 1 three"
+gdb_test "restart 2" "if .c == EOF.*" "restart 2 three"
 gdb_test "continue" "breakpoint 2.*" "break2 2 one"
 gdb_test "print ftell (out) > 100000" " = 1.*" "outfile still open 2"
 
-gdb_test "restart 3" "if .c == EOF.*" "restart 1 three"
+gdb_test "restart 3" "if .c == EOF.*" "restart 3 three"
 gdb_test "continue" "breakpoint 2.*" "break2 3 one"
 gdb_test "print ftell (out) > 100000" " = 1.*" "outfile still open 3"
 
-gdb_test "restart 4" "if .c == EOF.*" "restart 1 three"
+gdb_test "restart 4" "if .c == EOF.*" "restart 4 three"
 gdb_test "continue" "breakpoint 2.*" "break2 4 one"
 gdb_test "print ftell (out) > 100000" " = 1.*" "outfile still open 4"
 
-gdb_test "restart 5" "if .c == EOF.*" "restart 1 three"
+gdb_test "restart 5" "if .c == EOF.*" "restart 5 three"
 gdb_test "continue" "breakpoint 2.*" "break2 5 one"
 gdb_test "print ftell (out) > 100000" " = 1.*" "outfile still open 5"
 
-gdb_test "restart 6" "if .c == EOF.*" "restart 1 three"
+gdb_test "restart 6" "if .c == EOF.*" "restart 6 three"
 gdb_test "continue" "breakpoint 2.*" "break2 6 one"
 gdb_test "print ftell (out) > 100000" " = 1.*" "outfile still open 6"
 
-gdb_test "restart 7" "if .c == EOF.*" "restart 1 three"
+gdb_test "restart 7" "if .c == EOF.*" "restart 7 three"
 gdb_test "continue" "breakpoint 2.*" "break2 7 one"
 gdb_test "print ftell (out) > 100000" " = 1.*" "outfile still open 7"
 
-gdb_test "restart 8" "if .c == EOF.*" "restart 1 three"
+gdb_test "restart 8" "if .c == EOF.*" "restart 8 three"
 gdb_test "continue" "breakpoint 2.*" "break2 8 one"
 gdb_test "print ftell (out) > 100000" " = 1.*" "outfile still open 8"
 
-gdb_test "restart 9" "if .c == EOF.*" "restart 1 three"
+gdb_test "restart 9" "if .c == EOF.*" "restart 9 three"
 gdb_test "continue" "breakpoint 2.*" "break2 9 one"
 gdb_test "print ftell (out) > 100000" " = 1.*" "outfile still open 9"
 
-gdb_test "restart 10" "if .c == EOF.*" "restart 1 three"
+gdb_test "restart 10" "if .c == EOF.*" "restart 10 three"
 gdb_test "continue" "breakpoint 2.*" "break2 10 one"
 gdb_test "print ftell (out) > 100000" " = 1.*" "outfile still open 10"
 

Re: [patch] Make test messages unique in checkpoint.exp

[Yao Qi]

On 01/17/2013 08:10 PM, Abid, Hafiz wrote:
> gdb/testsuite:
>
> 2013-01-17  Hafiz Abid Qadeer<abidh@codesourcery.com>
>
> 	* gdb.base/checkpoint.exp: Update test messages to make them unique.

This line is too long.  This patch can be regarded as a partial fix to 
PR 13443, so we can put "PR gdb/13443" in the changelog entry, like this:
	PR gdb/13443
	* gdb.base/checkpoint.exp: Update test messages to make them
	unique.

so the commit will be associated with that PR in bugzilla.

-- 
Yao (齐尧)

Re: [patch] Make test messages unique in checkpoint.exp

[Tom Tromey]

>>>>> "Abid" == Abid, Hafiz <Hafiz_Abid@mentor.com> writes:

Abid> While looking at the checkpoint.exp, I noted that there were many
Abid> tests with same messages. I updated the messages so that they are
Abid> unique following the convention already used in the file. How does it
Abid> look?

The patch is ok with the ChangeLog fix that Yao suggested.

thanks,
Tom

Re: [patch] Make test messages unique in checkpoint.exp

[Hafiz Abid Qadeer]

On 17/01/13 15:57:26, Tom Tromey wrote:
> >>>>> "Abid" == Abid, Hafiz <Hafiz_Abid@mentor.com> writes:
> 
> Abid> While looking at the checkpoint.exp, I noted that there were  
> many
> Abid> tests with same messages. I updated the messages so that they  
> are
> Abid> unique following the convention already used in the file. How  
> does it
> Abid> look?
> 
> The patch is ok with the ChangeLog fix that Yao suggested.
> 
> thanks,
> Tom
> 

Thanks Tom and Yao for review. I have applied it after making the  
suggested change.

Regards,
Abid