From: "Abid, Hafiz" <Hafiz_Abid@mentor.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [patch] Make test messages unique in checkpoint.exp
Date: Thu, 17 Jan 2013 12:10:00 -0000 [thread overview]
Message-ID: <EB3B29AD43CA924DA27099BC8519237696CE8C7A@EU-MBX-03.mgc.mentorg.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 380 bytes --]
Hi,
While looking at the checkpoint.exp, I noted that there were many tests with same messages. I updated the messages so that they are unique following the convention already used in the file. How does it look?
Regards,
Abid
gdb/testsuite:
2013-01-17 Hafiz Abid Qadeer <abidh@codesourcery.com>
* gdb.base/checkpoint.exp: Update test messages to make them unique.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: checkpoint.patch --]
[-- Type: text/x-patch; name="checkpoint.patch", Size: 2578 bytes --]
diff --git a/gdb/testsuite/gdb.base/checkpoint.exp b/gdb/testsuite/gdb.base/checkpoint.exp
index f3366ee..d9c28e0 100644
--- a/gdb/testsuite/gdb.base/checkpoint.exp
+++ b/gdb/testsuite/gdb.base/checkpoint.exp
@@ -230,39 +230,39 @@ gdb_test "restart 1" "if .c == EOF.*" "restart 1 three"
gdb_test "continue" "breakpoint 2.*" "break2 1 one"
gdb_test "print ftell (out) > 100000" " = 1.*" "outfile still open 1"
-gdb_test "restart 2" "if .c == EOF.*" "restart 1 three"
+gdb_test "restart 2" "if .c == EOF.*" "restart 2 three"
gdb_test "continue" "breakpoint 2.*" "break2 2 one"
gdb_test "print ftell (out) > 100000" " = 1.*" "outfile still open 2"
-gdb_test "restart 3" "if .c == EOF.*" "restart 1 three"
+gdb_test "restart 3" "if .c == EOF.*" "restart 3 three"
gdb_test "continue" "breakpoint 2.*" "break2 3 one"
gdb_test "print ftell (out) > 100000" " = 1.*" "outfile still open 3"
-gdb_test "restart 4" "if .c == EOF.*" "restart 1 three"
+gdb_test "restart 4" "if .c == EOF.*" "restart 4 three"
gdb_test "continue" "breakpoint 2.*" "break2 4 one"
gdb_test "print ftell (out) > 100000" " = 1.*" "outfile still open 4"
-gdb_test "restart 5" "if .c == EOF.*" "restart 1 three"
+gdb_test "restart 5" "if .c == EOF.*" "restart 5 three"
gdb_test "continue" "breakpoint 2.*" "break2 5 one"
gdb_test "print ftell (out) > 100000" " = 1.*" "outfile still open 5"
-gdb_test "restart 6" "if .c == EOF.*" "restart 1 three"
+gdb_test "restart 6" "if .c == EOF.*" "restart 6 three"
gdb_test "continue" "breakpoint 2.*" "break2 6 one"
gdb_test "print ftell (out) > 100000" " = 1.*" "outfile still open 6"
-gdb_test "restart 7" "if .c == EOF.*" "restart 1 three"
+gdb_test "restart 7" "if .c == EOF.*" "restart 7 three"
gdb_test "continue" "breakpoint 2.*" "break2 7 one"
gdb_test "print ftell (out) > 100000" " = 1.*" "outfile still open 7"
-gdb_test "restart 8" "if .c == EOF.*" "restart 1 three"
+gdb_test "restart 8" "if .c == EOF.*" "restart 8 three"
gdb_test "continue" "breakpoint 2.*" "break2 8 one"
gdb_test "print ftell (out) > 100000" " = 1.*" "outfile still open 8"
-gdb_test "restart 9" "if .c == EOF.*" "restart 1 three"
+gdb_test "restart 9" "if .c == EOF.*" "restart 9 three"
gdb_test "continue" "breakpoint 2.*" "break2 9 one"
gdb_test "print ftell (out) > 100000" " = 1.*" "outfile still open 9"
-gdb_test "restart 10" "if .c == EOF.*" "restart 1 three"
+gdb_test "restart 10" "if .c == EOF.*" "restart 10 three"
gdb_test "continue" "breakpoint 2.*" "break2 10 one"
gdb_test "print ftell (out) > 100000" " = 1.*" "outfile still open 10"
next reply other threads:[~2013-01-17 12:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 12:10 Abid, Hafiz [this message]
2013-01-17 13:01 ` Yao Qi
2013-01-17 15:57 ` Tom Tromey
2013-01-18 12:48 ` Hafiz Abid Qadeer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EB3B29AD43CA924DA27099BC8519237696CE8C7A@EU-MBX-03.mgc.mentorg.com \
--to=hafiz_abid@mentor.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox