State of old format warning patch for Mac OS X

State of old format warning patch for Mac OS X

[Stan Shebs]

Whatever happened with Muranaka's patch in 
http://sourceware.org/ml/gdb-patches/2007-02/msg00160.html to fix the 
"format not a string literal" warnings on Mac OS X? I've been getting 
those complaints from vec.h expansions, this patch shuts them off very 
nicely.

Stan

Re: State of old format warning patch for Mac OS X

[Daniel Jacobowitz]

On Mon, Jul 14, 2008 at 03:38:35PM -0700, Stan Shebs wrote:
> Whatever happened with Muranaka's patch in  
> http://sourceware.org/ml/gdb-patches/2007-02/msg00160.html to fix the  
> "format not a string literal" warnings on Mac OS X? I've been getting  
> those complaints from vec.h expansions, this patch shuts them off very  
> nicely.

Nothing past the response in the list archives, AFAIK.

-- 
Daniel Jacobowitz
CodeSourcery

Re: State of old format warning patch for Mac OS X

[Masaki Muranaka]

Hello,

I guess GCC team have no interest in this issue as GCC is not built on  
OSX host.
(Usually OSX hackers use GCC provided by Apple.)

Then... what should I do to accept my patch.

On 2008/07/15, at 8:00, Daniel Jacobowitz wrote:

> On Mon, Jul 14, 2008 at 03:38:35PM -0700, Stan Shebs wrote:
>> Whatever happened with Muranaka's patch in
>> http://sourceware.org/ml/gdb-patches/2007-02/msg00160.html to fix the
>> "format not a string literal" warnings on Mac OS X? I've been getting
>> those complaints from vec.h expansions, this patch shuts them off  
>> very
>> nicely.
>
> Nothing past the response in the list archives, AFAIK.
>
> -- 
> Daniel Jacobowitz
> CodeSourcery
>

Masaki Muranaka
Monami Software

Re: State of old format warning patch for Mac OS X

[Stan Shebs]

Masaki Muranaka wrote:
> Hello,
>
> I guess GCC team have no interest in this issue as GCC is not built on 
> OSX host.
> (Usually OSX hackers use GCC provided by Apple.)
>
> Then... what should I do to accept my patch.
I build GCC on OS X regularly, and don't remember seeing this warning, 
so maybe nothing in GCC sources triggers it. In any case, as 
src/intl/README says, this is a gettext patch ultimately and needs to go 
to them.

But since I see that it has been years since gettext has been imported, 
I'd say to just install this patch into src/ now - it's just a one-liner 
and if by some chance it gets missed in a hypothetical future import, 
it's easy to re-add. I'm guessing you don't have commit access? so I'll 
take care of it.

Stan
>
> On 2008/07/15, at 8:00, Daniel Jacobowitz wrote:
>
>> On Mon, Jul 14, 2008 at 03:38:35PM -0700, Stan Shebs wrote:
>>> Whatever happened with Muranaka's patch in
>>> http://sourceware.org/ml/gdb-patches/2007-02/msg00160.html to fix the
>>> "format not a string literal" warnings on Mac OS X? I've been getting
>>> those complaints from vec.h expansions, this patch shuts them off very
>>> nicely.
>>
>> Nothing past the response in the list archives, AFAIK.
>>
>> -- 
>> Daniel Jacobowitz
>> CodeSourcery
>>
>
> Masaki Muranaka
> Monami Software
>
>
>
>
>

Re: State of old format warning patch for Mac OS X

[Daniel Jacobowitz]

On Wed, Jul 23, 2008 at 08:24:19AM -0700, Stan Shebs wrote:
> But since I see that it has been years since gettext has been imported,  
> I'd say to just install this patch into src/ now - it's just a one-liner  
> and if by some chance it gets missed in a hypothetical future import,  
> it's easy to re-add. I'm guessing you don't have commit access? so I'll  
> take care of it.

Please check whether intl is currently in sync between gcc and src
first; if so (I think it is), it needs to go to gcc first.

-- 
Daniel Jacobowitz
CodeSourcery

Re: State of old format warning patch for Mac OS X

[Masaki Muranaka]

Hello,

// For GCC hackers,
// This issue is described at gdb-patches ML.
// Related mail is:
// http://sourceware.org/ml/gdb-patches/2008-07/msg00418.html

Today I inspected this issue again.
I think intl libraries and dependent sources are synchronized between gcc and src.

The direct reason of this issue is caused by -Wmissing-format-attribute.
For example, gcc/collect2.o will failed to build after you add -Wmissing-format-attribute in gcc/Makefile
 same as gdb/Makefile.

An easiest fix is removing -Wmissing-format-attribute from gdb/Makefile
But I don't like removing warning detections. I think libgnuintl.h will be patched.
How do you think, Daniel and GCC hackers?

On 2008/07/24, at 0:40, Daniel Jacobowitz wrote:

> On Wed, Jul 23, 2008 at 08:24:19AM -0700, Stan Shebs wrote:
>> But since I see that it has been years since gettext has been imported,  
>> I'd say to just install this patch into src/ now - it's just a one-liner  
>> and if by some chance it gets missed in a hypothetical future import,  
>> it's easy to re-add. I'm guessing you don't have commit access? so I'll  
>> take care of it.
>
> Please check whether intl is currently in sync between gcc and src
> first; if so (I think it is), it needs to go to gcc first.
>
> -- 
> Daniel Jacobowitz
> CodeSourcery
>

Masaki Muranaka
Monami Software

Re: State of old format warning patch for Mac OS X

[Ian Lance Taylor]

Masaki Muranaka <monaka@monami-software.com> writes:

> An easiest fix is removing -Wmissing-format-attribute from gdb/Makefile
> But I don't like removing warning detections. I think libgnuintl.h will be patched.
> How do you think, Daniel and GCC hackers?

I agree that the intl library should be patched.

Ian