From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1189 invoked by alias); 14 Dec 2008 05:03:13 -0000 Received: (qmail 1060 invoked by uid 22791); 14 Dec 2008 05:03:11 -0000 X-Spam-Check-By: sourceware.org Received: from p12018-ipbffx02marunouchi.tokyo.ocn.ne.jp (HELO mail.pizzafactory.jp) (222.147.75.18) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 14 Dec 2008 05:02:21 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.pizzafactory.jp (Postfix) with ESMTP id 0A7F2419EF7C; Sun, 14 Dec 2008 14:02:19 +0900 (JST) Received: from mail.pizzafactory.jp ([127.0.0.1]) by localhost (ldap.monami-software.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ii47ib6ZJEEx; Sun, 14 Dec 2008 14:02:18 +0900 (JST) Received: from poweredge.monami-software.com (www.monaka.org [192.168.0.251]) by mail.pizzafactory.jp (Postfix) with ESMTP id 55602419EF70; Sun, 14 Dec 2008 14:02:18 +0900 (JST) Received: from [192.168.0.220] (unknown [192.168.0.220]) by poweredge.monami-software.com (Postfix) with ESMTP id 311EF7D87; Sun, 14 Dec 2008 14:02:58 +0900 (JST) Cc: Stan Shebs , gdb-patches@sourceware.org, gcc-patches@gnu.org Message-Id: <03D3D3CE-DF8B-4056-BE17-46922301C82A@monami-software.com> From: Masaki Muranaka To: Daniel Jacobowitz In-Reply-To: <20080723154029.GA16569@caradoc.them.org> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v929.2) Subject: Re: State of old format warning patch for Mac OS X Date: Sun, 14 Dec 2008 05:03:00 -0000 References: <487BD56B.9040609@earthlink.net> <20080714230022.GA14011@caradoc.them.org> <48874D23.7050508@codesourcery.com> <20080723154029.GA16569@caradoc.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-12/txt/msg00253.txt.bz2 Hello, // For GCC hackers, // This issue is described at gdb-patches ML. // Related mail is: // http://sourceware.org/ml/gdb-patches/2008-07/msg00418.html Today I inspected this issue again. I think intl libraries and dependent sources are synchronized between gcc and src. The direct reason of this issue is caused by -Wmissing-format-attribute. For example, gcc/collect2.o will failed to build after you add -Wmissing-format-attribute in gcc/Makefile same as gdb/Makefile. An easiest fix is removing -Wmissing-format-attribute from gdb/Makefile But I don't like removing warning detections. I think libgnuintl.h will be patched. How do you think, Daniel and GCC hackers? On 2008/07/24, at 0:40, Daniel Jacobowitz wrote: > On Wed, Jul 23, 2008 at 08:24:19AM -0700, Stan Shebs wrote: >> But since I see that it has been years since gettext has been imported, >> I'd say to just install this patch into src/ now - it's just a one-liner >> and if by some chance it gets missed in a hypothetical future import, >> it's easy to re-add. I'm guessing you don't have commit access? so I'll >> take care of it. > > Please check whether intl is currently in sync between gcc and src > first; if so (I think it is), it needs to go to gcc first. > > -- > Daniel Jacobowitz > CodeSourcery > Masaki Muranaka Monami Software