Re: [RFA] Fix a windows bug if two watchpoints are used

[Eli Zaretskii <eliz@gnu.org>]

> From: "Pierre Muller" <muller@ics.u-strasbg.fr>
> Date: Thu, 4 Jun 2009 00:58:09 +0200
> 
>   Now comes the tricky part, why does that generate a
> SIGTRAP?
>   In i386_stopped_data_address,
> the bits of dr_status_mirror (copied from current value of dr[6]) 
> are checked from 0 to 3, but if hit is found for I,
> the address value is taken from dr_mirror array.
> 
>   Thus, according to dr[6], both debug registers 0 and 1
> have been hit.
>   at i=0, the correct address of ival3 is found in dr_mirror[0],
> but after for i=1, the value of dr_mirror[1] is used, but this
> value is 0, as only one watch is active.

Shouldn't we instead fix the logic of i386_stopped_data_address, to
get out of the loop on the first watchpoint that is found to be hit?
The function does not support more than one watchpoint anyway, so why
continue checking the bits in dr[6] after we've found one set already?

Would such a change fix your problem without the other complications?

Btw, I don't understand this part of i386_stopped_data_address:

  if (maint_show_dr && addr == 0)
    i386_show_dr ("stopped_data_addr", 0, 0, hw_write);

Isn't that backwards? why display the address if it is zero?