From: Vladimir Prus <ghost@cs.msu.su>
To: Nick Roberts <nickrob@snap.net.nz>, gdb-patches@sources.redhat.com
Subject: Re: [PATCH] MI: Free values when updating
Date: Wed, 24 Jan 2007 08:00:00 -0000 [thread overview]
Message-ID: <E1H9d3G-0003Qn-Mb@zigzag.lvk.cs.msu.su> (raw)
In-Reply-To: <17845.60212.898642.763807@kahikatea.snap.net.nz>
Nick Roberts wrote:
> > Index: varobj.c
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/varobj.c,v
> > retrieving revision 1.79
> > diff -u -p -r1.79 varobj.c
> > --- varobj.c 16 Jan 2007 02:12:49 -0000 1.79
> > +++ varobj.c 23 Jan 2007 09:12:07 -0000
> > @@ -1987,11 +1987,7 @@ c_value_of_root (struct varobj **var_han
> > /* We need to catch errors here, because if evaluate
> > expression fails we just want to make val->error = 1 and
> > go on */
>
> This comment is not applicable anymore.
It actually is -- the comment says why we use gdb_evaluate_expression,
as opposed to evaluate_expression. Only the part about val->error is obsolete,
and I'll fix that.
- Volodya
next prev parent reply other threads:[~2007-01-24 8:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-23 7:45 Nick Roberts
2007-01-23 7:55 ` Vladimir Prus
2007-01-23 8:56 ` Nick Roberts
2007-01-23 9:15 ` Vladimir Prus
2007-01-23 11:02 ` Nick Roberts
2007-01-23 12:12 ` Daniel Jacobowitz
2007-01-23 21:19 ` Nick Roberts
2007-01-23 21:35 ` Vladimir Prus
2007-01-24 8:00 ` Vladimir Prus [this message]
2007-01-24 9:14 ` Nick Roberts
2007-01-24 9:21 ` Vladimir Prus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1H9d3G-0003Qn-Mb@zigzag.lvk.cs.msu.su \
--to=ghost@cs.msu.su \
--cc=gdb-patches@sources.redhat.com \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox