From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27829 invoked by alias); 24 Jan 2007 08:00:31 -0000 Received: (qmail 27820 invoked by uid 22791); 24 Jan 2007 08:00:30 -0000 X-Spam-Check-By: sourceware.org Received: from zigzag.lvk.cs.msu.su (HELO zigzag.lvk.cs.msu.su) (158.250.17.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 24 Jan 2007 08:00:24 +0000 Received: from Debian-exim by zigzag.lvk.cs.msu.su with spam-scanned (Exim 4.50) id 1H9d3N-0003Qz-49 for gdb-patches@sources.redhat.com; Wed, 24 Jan 2007 11:00:21 +0300 Received: from localhost ([127.0.0.1] helo=ip6-localhost) by zigzag.lvk.cs.msu.su with esmtp (Exim 4.50) id 1H9d3G-0003Qn-Mb; Wed, 24 Jan 2007 11:00:14 +0300 From: Vladimir Prus Subject: Re: [PATCH] MI: Free values when updating To: Nick Roberts , gdb-patches@sources.redhat.com Date: Wed, 24 Jan 2007 08:00:00 -0000 References: <17845.48393.877158.536969@kahikatea.snap.net.nz> <17845.60212.898642.763807@kahikatea.snap.net.nz> User-Agent: KNode/0.10.2 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit Message-Id: Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00492.txt.bz2 Nick Roberts wrote: > > Index: varobj.c > > =================================================================== > > RCS file: /cvs/src/src/gdb/varobj.c,v > > retrieving revision 1.79 > > diff -u -p -r1.79 varobj.c > > --- varobj.c 16 Jan 2007 02:12:49 -0000 1.79 > > +++ varobj.c 23 Jan 2007 09:12:07 -0000 > > @@ -1987,11 +1987,7 @@ c_value_of_root (struct varobj **var_han > > /* We need to catch errors here, because if evaluate > > expression fails we just want to make val->error = 1 and > > go on */ > > This comment is not applicable anymore. It actually is -- the comment says why we use gdb_evaluate_expression, as opposed to evaluate_expression. Only the part about val->error is obsolete, and I'll fix that. - Volodya