From: Nick Roberts <nickrob@snap.net.nz>
To: Vladimir Prus <ghost@cs.msu.su>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] MI: Free values when updating
Date: Wed, 24 Jan 2007 09:14:00 -0000 [thread overview]
Message-ID: <17847.9067.795191.960722@kahikatea.snap.net.nz> (raw)
In-Reply-To: <E1H9d3G-0003Qn-Mb@zigzag.lvk.cs.msu.su>
> > > @@ -1987,11 +1987,7 @@ c_value_of_root (struct varobj **var_han
> > > /* We need to catch errors here, because if evaluate
> > > expression fails we just want to make val->error = 1 and
> > > go on */
> >
> > This comment is not applicable anymore.
>
> It actually is -- the comment says why we use gdb_evaluate_expression,
> as opposed to evaluate_expression. Only the part about val->error is obsolete,
> and I'll fix that.
I'm not even sure that current use of gdb_evaluate_expression with variable
objects is sensible. Currently GDB accepts:
-var-create - * 1/0
and if you do:
-var-create - * n1/n2
and n2 is set to 0, with "-var-update --all-values", GDB returns:
^done,changelist=[{name="var2",in_scope="false"}]
--
Nick http://www.inet.net.nz/~nickrob
next prev parent reply other threads:[~2007-01-24 9:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-23 7:45 Nick Roberts
2007-01-23 7:55 ` Vladimir Prus
2007-01-23 8:56 ` Nick Roberts
2007-01-23 9:15 ` Vladimir Prus
2007-01-23 11:02 ` Nick Roberts
2007-01-23 12:12 ` Daniel Jacobowitz
2007-01-23 21:19 ` Nick Roberts
2007-01-23 21:35 ` Vladimir Prus
2007-01-24 8:00 ` Vladimir Prus
2007-01-24 9:14 ` Nick Roberts [this message]
2007-01-24 9:21 ` Vladimir Prus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17847.9067.795191.960722@kahikatea.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=gdb-patches@sources.redhat.com \
--cc=ghost@cs.msu.su \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox