From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23213 invoked by alias); 24 Jan 2007 09:14:43 -0000 Received: (qmail 23197 invoked by uid 22791); 24 Jan 2007 09:14:40 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 24 Jan 2007 09:14:34 +0000 Received: from kahikatea.snap.net.nz (204.63.255.123.dynamic.snap.net.nz [123.255.63.204]) by viper.snap.net.nz (Postfix) with ESMTP id 29AB13D81E9; Wed, 24 Jan 2007 22:14:30 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id B7DAB4F71D; Wed, 24 Jan 2007 22:14:23 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17847.9067.795191.960722@kahikatea.snap.net.nz> Date: Wed, 24 Jan 2007 09:14:00 -0000 To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] MI: Free values when updating In-Reply-To: References: <17845.48393.877158.536969@kahikatea.snap.net.nz> <17845.60212.898642.763807@kahikatea.snap.net.nz> X-Mailer: VM 7.19 under Emacs 22.0.93.1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00495.txt.bz2 > > > @@ -1987,11 +1987,7 @@ c_value_of_root (struct varobj **var_han > > > /* We need to catch errors here, because if evaluate > > > expression fails we just want to make val->error = 1 and > > > go on */ > > > > This comment is not applicable anymore. > > It actually is -- the comment says why we use gdb_evaluate_expression, > as opposed to evaluate_expression. Only the part about val->error is obsolete, > and I'll fix that. I'm not even sure that current use of gdb_evaluate_expression with variable objects is sensible. Currently GDB accepts: -var-create - * 1/0 and if you do: -var-create - * n1/n2 and n2 is set to 0, with "-var-update --all-values", GDB returns: ^done,changelist=[{name="var2",in_scope="false"}] -- Nick http://www.inet.net.nz/~nickrob