From: Vladimir Prus <ghost@cs.msu.su>
To: Daniel Jacobowitz <drow@false.org>, gdb-patches@sources.redhat.com
Subject: Re: Fix 'selected frame' varobjs
Date: Tue, 16 Jan 2007 02:14:00 -0000 [thread overview]
Message-ID: <E1H6dpf-0005jj-HM@zigzag.lvk.cs.msu.su> (raw)
In-Reply-To: <20070109214514.GF30631@nevyn.them.org>
Daniel Jacobowitz wrote:
> On Wed, Jan 10, 2007 at 12:20:55AM +0300, Vladimir Prus wrote:
>> What about the attached?
>>
>> - Volodya
>>
>> 2006-12-31 Daniel Jacobowitz <dan@codesourcery.com>
>> Vladimir Prus <vladimir@codesourcery.com>
>>
>> Fix 'selected frame' varobjs.
>> * varobj.c (struct varobj): Remove the error field.
>> (varobj_set_value): Don't check var->error.
>> (install_new_value): Don't set var->error.
>> (varobj_update): Always pass the new value
>> of the root via install_new_value.
>> (create_child): Don't set error field.
>> (new_variable): Likewise.
>> (c_value_of_root): Always reevaluate the value
>> of selected frame varobjs in the selected frame.
>> Don't call reinit_frame_cache.
>
> Looks good to me - this is OK.
Checked in, thanks.
- Volodya
prev parent reply other threads:[~2007-01-16 2:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-31 0:02 Vladimir Prus
2006-12-31 21:42 ` Daniel Jacobowitz
2007-01-09 21:22 ` Vladimir Prus
2007-01-09 21:45 ` Daniel Jacobowitz
2007-01-16 2:14 ` Vladimir Prus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1H6dpf-0005jj-HM@zigzag.lvk.cs.msu.su \
--to=ghost@cs.msu.su \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox