From: Daniel Jacobowitz <drow@false.org>
To: Vladimir Prus <ghost@cs.msu.su>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Fix 'selected frame' varobjs
Date: Sun, 31 Dec 2006 21:42:00 -0000 [thread overview]
Message-ID: <20061231214221.GB26604@nevyn.them.org> (raw)
In-Reply-To: <200612310301.42649.ghost@cs.msu.su>
On Sun, Dec 31, 2006 at 03:01:42AM +0300, Vladimir Prus wrote:
> @@ -1061,6 +1061,14 @@ varobj_update (struct varobj **varp, str
> if (new == NULL)
> {
> (*varp)->error = 1;
> + /* Also set the value to NULL, so that
> + when the value becomes valid in future,
> + -var-update notice the change. */
> + if ((*varp)->value != NULL)
> + {
> + value_free ((*varp)->value);
> + (*varp)->value = NULL;
> + }
> return -1;
> }
>
"in the future", "notices the change". Should we be doing this
everywhere that we set var->error (probably add a new helper to do
that)? There's about a half-dozen places.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-12-31 21:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-31 0:02 Vladimir Prus
2006-12-31 21:42 ` Daniel Jacobowitz [this message]
2007-01-09 21:22 ` Vladimir Prus
2007-01-09 21:45 ` Daniel Jacobowitz
2007-01-16 2:14 ` Vladimir Prus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061231214221.GB26604@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=ghost@cs.msu.su \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox