From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32571 invoked by alias); 31 Dec 2006 21:42:31 -0000 Received: (qmail 32563 invoked by uid 22791); 31 Dec 2006 21:42:30 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sun, 31 Dec 2006 21:42:26 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1H18Rh-00070e-3z; Sun, 31 Dec 2006 16:42:21 -0500 Date: Sun, 31 Dec 2006 21:42:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: Fix 'selected frame' varobjs Message-ID: <20061231214221.GB26604@nevyn.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200612310301.42649.ghost@cs.msu.su> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200612310301.42649.ghost@cs.msu.su> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00424.txt.bz2 On Sun, Dec 31, 2006 at 03:01:42AM +0300, Vladimir Prus wrote: > @@ -1061,6 +1061,14 @@ varobj_update (struct varobj **varp, str > if (new == NULL) > { > (*varp)->error = 1; > + /* Also set the value to NULL, so that > + when the value becomes valid in future, > + -var-update notice the change. */ > + if ((*varp)->value != NULL) > + { > + value_free ((*varp)->value); > + (*varp)->value = NULL; > + } > return -1; > } > "in the future", "notices the change". Should we be doing this everywhere that we set var->error (probably add a new helper to do that)? There's about a half-dozen places. -- Daniel Jacobowitz CodeSourcery