From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-47203-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13711 invoked by alias); 16 Jan 2007 02:14:20 -0000
Received: (qmail 13685 invoked by uid 22791); 16 Jan 2007 02:14:19 -0000
X-Spam-Check-By: sourceware.org
Received: from zigzag.lvk.cs.msu.su (HELO zigzag.lvk.cs.msu.su) (158.250.17.23)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 16 Jan 2007 02:14:14 +0000
Received: from Debian-exim by zigzag.lvk.cs.msu.su with spam-scanned (Exim 4.50) 	id 1H6dpt-0005kV-TY 	for gdb-patches@sources.redhat.com; Tue, 16 Jan 2007 05:14:11 +0300
Received: from localhost ([127.0.0.1] helo=ip6-localhost) 	by zigzag.lvk.cs.msu.su with esmtp (Exim 4.50) 	id 1H6dpf-0005jj-HM; Tue, 16 Jan 2007 05:13:51 +0300
From: Vladimir Prus <ghost@cs.msu.su>
Subject: Re: Fix 'selected frame' varobjs
To: Daniel Jacobowitz <drow@false.org>, gdb-patches@sources.redhat.com
Date: Tue, 16 Jan 2007 02:14:00 -0000
References: <200612310301.42649.ghost@cs.msu.su> <20061231214221.GB26604@nevyn.them.org> <E1H4OPc-0008Mo-NF@zigzag.lvk.cs.msu.su> <20070109214514.GF30631@nevyn.them.org>
User-Agent: KNode/0.10.2
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7Bit
Message-Id: <E1H6dpf-0005jj-HM@zigzag.lvk.cs.msu.su>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-01/txt/msg00352.txt.bz2

Daniel Jacobowitz wrote:

> On Wed, Jan 10, 2007 at 12:20:55AM +0300, Vladimir Prus wrote:
>> What about the attached?
>> 
>> - Volodya
>> 
>> 2006-12-31  Daniel Jacobowitz  <dan@codesourcery.com>
>>             Vladimir Prus  <vladimir@codesourcery.com>
>> 
>>         Fix 'selected frame' varobjs.
>>         * varobj.c (struct varobj): Remove the error field.
>>         (varobj_set_value): Don't check var->error.
>>         (install_new_value): Don't set var->error.
>>         (varobj_update): Always pass the new value
>>         of the root via install_new_value.
>>         (create_child): Don't set error field.
>>         (new_variable): Likewise.
>>         (c_value_of_root): Always reevaluate the value
>>         of selected frame varobjs in the selected frame.
>>         Don't call reinit_frame_cache.
> 
> Looks good to me - this is OK.

Checked in, thanks.

- Volodya