Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Aditya Kamath <Aditya.Kamath1@ibm.com>
To: Tom Tromey <tom@tromey.com>,
	Aditya Vidyadhar Kamath <akamath996@gmail.com>
Cc: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>,
	"simon.marchi@polymtl.ca" <simon.marchi@polymtl.ca>,
	"tom@tromey.com" <tom@tromey.com>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	SANGAMESH MALLAYYA <sangamesh.swamy@in.ibm.com>
Subject: RE: [PATCH] Fix crash when target-wide-charset doesn't match wchar_t size
Date: Wed, 21 Oct 2026 09:01:01 +0000	[thread overview]
Message-ID: <DSWPR15MB3198177EBC4575A809B4BA7372D6662@DSWPR15MB319817.namprd15.prod.outlook.com> (raw)
In-Reply-To: <874ieh3dnc.fsf@tromey.com>

[-- Attachment #1: Type: text/plain, Size: 964 bytes --]

Hi Tom,

Thanks for the review. I am sending v2 version of this patch.

>>>>>> Aditya Vidyadhar Kamath <akamath996@gmail.com> writes:

>> +         error (_ ("Character set `%s' has a %d-byte character width “
>> +                   "but `wchar_t' on this target is %d bytes wide.\n”
>> +                   "Use `set target-wide-charset auto' to let GDB “
>> +                   "choose the correct encoding automatically.”),
>> +                target_wide_cset, charset_width, wchar_bytes);

>I think we should move away from the `...' style of quoting.
>I've been using "..." instead.

Changed this in charset.c and in the test case as well.

>Also "set target-wide-charset auto" should use the command style.

Now we use this.
+              styled_string (command_style.style (),
+                         "set target-wide-charset auto"));

Regards,
Aditya.

[-- Attachment #2: Type: text/html, Size: 3009 bytes --]

      reply	other threads:[~2026-10-21  9:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 12:05 Aditya Vidyadhar Kamath
2026-10-16 12:47 ` Simon Marchi
2026-10-16 13:40   ` Aditya Kamath
2026-10-19 15:37 ` Tom Tromey
2026-10-21  9:01   ` Aditya Kamath [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DSWPR15MB3198177EBC4575A809B4BA7372D6662@DSWPR15MB319817.namprd15.prod.outlook.com \
    --to=aditya.kamath1@ibm.com \
    --cc=Ulrich.Weigand@de.ibm.com \
    --cc=akamath996@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sangamesh.swamy@in.ibm.com \
    --cc=simon.marchi@polymtl.ca \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox