Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Aditya Vidyadhar Kamath <akamath996@gmail.com>
Cc: ulrich.weigand@de.ibm.com,  simon.marchi@polymtl.ca,
	 tom@tromey.com, gdb-patches@sourceware.org,
	 Aditya.Kamath1@ibm.com, sangamesh.swamy@in.ibm.com
Subject: Re: [PATCH] Fix crash when target-wide-charset doesn't match wchar_t size
Date: Mon, 19 Oct 2026 09:37:11 -0600	[thread overview]
Message-ID: <874ieh3dnc.fsf@tromey.com> (raw)
In-Reply-To: <20261016120502.88374-2-akamath996@gmail.com> (Aditya Vidyadhar Kamath's message of "Fri, 16 Oct 2026 17:35:03 +0530")

>>>>> Aditya Vidyadhar Kamath <akamath996@gmail.com> writes:

> +	    error (_ ("Character set `%s' has a %d-byte character width "
> +		      "but `wchar_t' on this target is %d bytes wide.\n"
> +		      "Use `set target-wide-charset auto' to let GDB "
> +		      "choose the correct encoding automatically."),
> +		   target_wide_cset, charset_width, wchar_bytes);

I think we should move away from the `...' style of quoting.
I've been using "..." instead.

Also "set target-wide-charset auto" should use the command style.

Tom

  parent reply	other threads:[~2026-10-19 15:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 12:05 Aditya Vidyadhar Kamath
2026-10-16 12:47 ` Simon Marchi
2026-10-16 13:40   ` Aditya Kamath
2026-10-19 15:37 ` Tom Tromey [this message]
2026-10-21  9:01   ` Aditya Kamath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874ieh3dnc.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=Aditya.Kamath1@ibm.com \
    --cc=akamath996@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sangamesh.swamy@in.ibm.com \
    --cc=simon.marchi@polymtl.ca \
    --cc=ulrich.weigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox