Hi Tom, Thanks for the review. I am sending v2 version of this patch. >>>>>> Aditya Vidyadhar Kamath writes: >> + error (_ ("Character set `%s' has a %d-byte character width “ >> + "but `wchar_t' on this target is %d bytes wide.\n” >> + "Use `set target-wide-charset auto' to let GDB “ >> + "choose the correct encoding automatically.”), >> + target_wide_cset, charset_width, wchar_bytes); >I think we should move away from the `...' style of quoting. >I've been using "..." instead. Changed this in charset.c and in the test case as well. >Also "set target-wide-charset auto" should use the command style. Now we use this. +            styled_string (command_style.style (), +                        "set target-wide-charset auto")); Regards, Aditya.