RE: [PATCH 1/2] gdbserver, read_ptid: handle '0' and '-1' thread ids

["Metzger, Markus T" <markus.t.metzger@intel.com>]

Hello Tom,

>> They are more different than it first appears.  The gdbserver side
>> accepts pN.-1, for example, while the gdb side doesn't.  The gdb side
>> doesn't accept -1 at all.
>
>> When the string does not start with 'p', both fall back to the
>> respective inferior on either side, but gdb has special handling for a
>> not-yet-known process id, whereas the gdbserver side doesn't.
>
>
>I haven't been following this super closely, but there's also a bugzilla
>bug in this area:
>
>https://sourceware.org/bugzilla/show_bug.cgi?id=25111

That seems to be caused by truncating a long ptid.tid to int before
writing it out.

In general, read_ptid() and write_ptid() don't seem to care about
types and conversions; read_ptid(), for example, reads everything
into ULONGEST and then constructs a ptid without checking for
overflows.

I could add a fix to this series, but, as with the other patches, this
would be solely based on reviewing the code without an actual bug
(I cannot test this zephyr target) nor a test.

Regards,
Markus.

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928