From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MYQeBTWm02jnpxAAWB0awg (envelope-from ) for ; Wed, 24 Sep 2025 04:05:09 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=L5wPXpeS; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0EB031E047; Wed, 24 Sep 2025 04:05:09 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3358B1E047 for ; Wed, 24 Sep 2025 04:05:08 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CF6D13858D39 for ; Wed, 24 Sep 2025 08:05:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CF6D13858D39 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=L5wPXpeS Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by sourceware.org (Postfix) with ESMTPS id C084A3858D26 for ; Wed, 24 Sep 2025 08:04:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C084A3858D26 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C084A3858D26 Authentication-Results: server2.sourceware.org; arc=fail smtp.remote-ip=192.198.163.16 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1758701073; cv=fail; b=tnkb3vNfLFnSkF3PgytODnSn+JeNtgDmkPHUaB/S613OARtYb0UQU0rd/fkt9HYwc18DUNHz7Z0HeCePRfLGNXqb31z4U/umVuLP92GGdk0N1twj9rnf2BD4SxkSMcjlrDzx+dSeJtJ11XvLFyHfuOlcEmphiyrXCo2j7/jKrfw= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1758701073; c=relaxed/simple; bh=6EkVuGaoLx6chW2WyRRyJq2B9kzox3G6FPlngM2Zr3A=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=BJcTHC0Jr2ltCFjvvjQSjlrOMmbT2+ayNBVKlhQfXm02oS5w7rLevmfGeig4VyMugL5JZf6coevrxGCP3U+Aa0FLWK7txKKgC+/oAiQQI2gL303IDCwOJEu1bj5oUDoiium5Rao8X1bd2SySkGXghjE46qiMYCCXRbfw9DAHASM= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C084A3858D26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1758701073; x=1790237073; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=6EkVuGaoLx6chW2WyRRyJq2B9kzox3G6FPlngM2Zr3A=; b=L5wPXpeSAtrc3AddP+LoXuTd8rdVSTi6GBv3S93rsGRkSbZJAbNP7I3h Szo72XmncOrSr9ITETpKIdIZuuRdBWZRy9HTlxkQbUnw77rZTnLVBFrDQ phgvZd9JnEVt4dWUwKIKK5jjttXWfAONUv3ZJ//9uyauN1w1+xkbPNGAj M0N1/iQ5SYxgHU5Uue8KW/d5DbEc/BlS/D/rPcrCmQTW+Pja4lzBgWVr1 9ANBJ9Fo6ewOo+cWjE5/WMnm7gc7b4r+1Zcf8redYYnekkXkyiDFfRmG6 wMy6F0yu9eF+MRCjeyhzJc+CDT+9Fl2zr0o+Pv8hCpYAu8izBjAG7fsM/ g==; X-CSE-ConnectionGUID: wNA6+40fRHqT2QBodtZDOA== X-CSE-MsgGUID: Lli+g60dQAC2b/vkZYbBDA== X-IronPort-AV: E=McAfee;i="6800,10657,11561"; a="48557101" X-IronPort-AV: E=Sophos;i="6.18,290,1751266800"; d="scan'208";a="48557101" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2025 01:04:30 -0700 X-CSE-ConnectionGUID: ULh6t7INTt6rgGYTvOhn3Q== X-CSE-MsgGUID: NRM3+eQPSk211fk4Vz/HNQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,290,1751266800"; d="scan'208";a="176262072" Received: from orsmsx903.amr.corp.intel.com ([10.22.229.25]) by orviesa010.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2025 01:04:29 -0700 Received: from ORSMSX903.amr.corp.intel.com (10.22.229.25) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.27; Wed, 24 Sep 2025 01:04:28 -0700 Received: from ORSEDG901.ED.cps.intel.com (10.7.248.11) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.27 via Frontend Transport; Wed, 24 Sep 2025 01:04:28 -0700 Received: from BL0PR03CU003.outbound.protection.outlook.com (52.101.53.4) by edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 24 Sep 2025 01:04:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oTvkJpY1ce/4ThQ7xS/J/0uXz8OaZzSM3WZGVHVr4dJPCunG+xrp6labPmuohsCQAtevP8jGXPGFv3byq9OufsfQCrDNg6Fip+1kGW+AQIpRWFUPFW5rR7VLy8akPWmFJiYMy44MnQsS68wBHgMeokoA1ecT1ZauJSIVNehFLX0xoVcqTuSqmI8FfWF66S1a/+5tfOp8DXKG1E0Q2KM5irpQ72TmDcCkaYrKwUYjHDjWH6Ssrcwn7VDLH4H7sjI6sY14FKfOoip7VJail+vaiQdtIcLlGZq9dERZ9L1TbU0cWOt8bDxUnlAYYhbuL0WQ7/yPaJORUsPaJfEvxGbIvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gaUMyNVSd6nd0T+x9SddxZdEZEk6Ws74D4uPPJF0YAk=; b=VUpwerdmJW4yTR7KY60BZkYcCoFwWSz3ZjN0NgCzlQiolvhoVekfv+0XGhOX/7x6T3ZK/DfMwEgT+Yh7Ua54l8F7YK7zEAc9DaCsbrrP/npLMcBje+4LEMQV1lqe8cdj4/+nThPjuviKIFc2ZSCZuOUDK+b8RVMsD3LqudlWFJBVEL9Y3cHAv1zW8XZWSmlgcURPhwpRHr8pLu8fTFMajpfrErejHL2JqP39ByLLYGzfGADzW8nFj+w2Dew9sAF54l/mmNGa1CqmvugAsaNgNEje2m/h8fzf9FyPC/upSJUwoyVzHSzPBCwwHAuKYNFV1jnd1vM8NgSCuWJNlTerTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by CY8PR11MB7193.namprd11.prod.outlook.com (2603:10b6:930:91::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9137.20; Wed, 24 Sep 2025 08:04:24 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::d0bb:6f87:88ed:6368]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::d0bb:6f87:88ed:6368%3]) with mapi id 15.20.9137.018; Wed, 24 Sep 2025 08:04:24 +0000 From: "Metzger, Markus T" To: Tom Tromey CC: Simon Marchi , Thiago Jung Bauermann , "gdb-patches@sourceware.org" Subject: RE: [PATCH 1/2] gdbserver, read_ptid: handle '0' and '-1' thread ids Thread-Topic: [PATCH 1/2] gdbserver, read_ptid: handle '0' and '-1' thread ids Thread-Index: AQHcBdlG/SsaDrNrtEGD6+PKCQKNA7Rhjb/JgAEd2wCAPMv9AIAB7A+SgADhBnA= Date: Wed, 24 Sep 2025 08:04:23 +0000 Message-ID: References: <20250805071914.3832823-1-markus.t.metzger@intel.com> <87wm76zi98.fsf@linaro.org> <4bc68b3a-d8a5-45b1-aa94-0b6af488d8bc@simark.ca> <87segdc9e9.fsf@tromey.com> In-Reply-To: <87segdc9e9.fsf@tromey.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8PR11MB5749:EE_|CY8PR11MB7193:EE_ x-ms-office365-filtering-correlation-id: 4e66dec4-882e-4a29-8119-08ddfb40f9a7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|376014|1800799024|38070700021; x-microsoft-antispam-message-info: =?us-ascii?Q?4uNxj5ig60rsaQEj6cZeyHOdu/AMxI3alPaf80TXzf6RAx6e0Vp9PNgCuQHQ?= =?us-ascii?Q?6fcEEnHGMWq/9k0D5qFymRuXqzbGLjgcTg0hdOP+XQoabMyf7AY+DY7p/NHT?= =?us-ascii?Q?KoUqE5PV5LF2LY+Ir7csKU7YjvYOjmtuVeTz6vs2aSntlpIQQoAq/Z90j1M2?= =?us-ascii?Q?sZzI/V6yqMnYBRqF8hsYuomFFuTvonMhGDilRXHud3o6slS0RA8ciHIBJW2W?= =?us-ascii?Q?Mqmo28mdP7z68RNnr/n0J4B8hpKPWbWDazKWgFUTf5XMQcCy8EogooeQj1Xp?= =?us-ascii?Q?LXAT5EAKQnMWrn5Y174DK+C4rBlF+Bdj3YZ06X1Bgf4DNwqhnTUA2M0nfPdo?= =?us-ascii?Q?LAixEkbIGjFbGQeCNdNAKqGRd6loArZEmR6p2IC5RTD52NqHIODD64wOfcfQ?= =?us-ascii?Q?9K3VwqxxctkdtWprDTEL1eP1xeZutSSDVTTvb7J14JrYdT9FCy0XhfTSt/m8?= =?us-ascii?Q?R6/L8JSsKJ/XASXmpBwWcqksqjRixau9qvtOEX8uftjprSdn+zYxb+6RdRcc?= =?us-ascii?Q?xhulLlpAkx7RUlICiS5YwRmy3gUNW7TBb0TdBh3T/Z0YdnCYVoEUzUgKQZXK?= =?us-ascii?Q?E0CVBv3BijPk6XxNJUGZSIOlndp7bW60RyZ7eRIejEp2qJBrE5VdYFs2AKiy?= =?us-ascii?Q?TYfPqg2HvevMlruQ2kEZZNBfGufYI0x9aRQhrjkgjR1/j8ymH1a8p3wxfPRb?= =?us-ascii?Q?B/hDhtknBAIFrO/baaAFw2J+i2AdpmdRK9d0/ba4SRSPxm3++u76BCIvB/Pi?= =?us-ascii?Q?Eo05+Jh/fa4S8ZhK33P6idDkd7aloa8XRkfUfl8PUWxFUAkL01APxY8vFWX/?= =?us-ascii?Q?flCu0BeR75+abAOuqSTR8RFgGbUqfGB35EmRdKTuQcPC2vhep9zpdaasLJgU?= =?us-ascii?Q?hzIwEl7g/u0dNwqVAwbsUnWoQebs4sQ07722zO8ror+4LrD2vHr/zctkPyup?= =?us-ascii?Q?r7D3BZcE/ak3JeYrxH51mQx1q1/61T960wFBEsvAbnPdevWGBb0VbpJpsE81?= =?us-ascii?Q?gSIgX2+PrXlnqvpgTz2Toab7Kl467O9nGq1jmserAU5vM4MPJHi4DTO6JLbv?= =?us-ascii?Q?PT1ApiHjf9a3BbgCB3dGjrW7U7il6AhFduOqB4hHw8uXXJe+9srVdvlBmJ8u?= =?us-ascii?Q?SGJkANC8XDxkXLC23Bo4pH16Qj1WYAMn0OwYuFUJgfgRaOyQ8nXtOYXHNWMj?= =?us-ascii?Q?hQhiBczI8+r7B7ykDFQ0ZnuCP44KVz1l0U/2sjy2Ad8w1xZBClTkIA1/xyTg?= =?us-ascii?Q?qW34SC0tejAkyg78eboBTXo2s8o7mVxq2GMyiS+H+2+DPb8mfN3ga0dX3TnV?= =?us-ascii?Q?fs3eFJ1A40ZfQ/I9fJJmMwjfRG89QTqQEpi8X8hjCoPxp7ZYbLVWWyxk4phi?= =?us-ascii?Q?IJZ2zi9ndSzmg4lJGxjObW9Y+VnzL7E4ItjeGtRUgdDl8rpz7OL647Bnzgzr?= =?us-ascii?Q?p6v+Vy0YWWMzLD72jrOPpBqf0T6vOVA5Jipkou4eVcvNqe3naIk+mGyRh27k?= =?us-ascii?Q?FEnFIzaGdtlT5/Y=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5749.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(38070700021); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MmirtHhu/qnrc/x9peR99m2FGro8VnWAcwdrJaFsimX77pAeKMxLWq2r1Tw/?= =?us-ascii?Q?iM6PXdMc0leoGQ1XYJMVcHlggR/oWM9UiYagBLF3LMmFt0pqhJK5VxdiLs4J?= =?us-ascii?Q?TolTSKeVc+sRU+/9i9nbvOEDzpjQ0OeeKV5D6m4+0ofOZK0Lqln2KfEE0l4J?= =?us-ascii?Q?+sSh+W4KJj0R+HyGDGsm2vjbg+Bbk082JEeR265fTBUyTnJcCJVHogxhJHcj?= =?us-ascii?Q?E4/6xVo7tPPp5Q9okF/zTtTRR9DJwVPGO8fWNAR0JEzBS1Tgizj6Z993/Zlu?= =?us-ascii?Q?pQ/VF4AabjhwQgo30jVGSdAU0Qmwn5SYtmk1ydrJQYAAE8wi2nM36zRu1ETv?= =?us-ascii?Q?qcNCcVGBAP3uM25+YRWwUHCwHVw9BmAMblByXVFifZfjHSg9nx0Yue5otTIN?= =?us-ascii?Q?iqyvkBPR8XAkEebChwr5p6unorBGuyoSS5jjaGtmBnKS2+gpBmBGfKVODzxS?= =?us-ascii?Q?iSMT2c4qh8/5kin4T8eT2FCTo/m5o4wJaSZSFzKM9kWfr/QMOoHGGMmtN/VD?= =?us-ascii?Q?6Ax0HRw5EEyE4vabwVR+PtzyfHP4QX8wzd8Xf3w4ea/q+trIOUuJmoT8BDKg?= =?us-ascii?Q?WIEd0I1lUMlBWVKskq0xO+NIi5rtatPAqduOCTsm2gEB/30sQ83gAoPC8IQ8?= =?us-ascii?Q?yhw+0dteI2mAz54q8qZGx3mPO+fVGyURFxc8Ielb/pCKFp+XsdOvMek3N6jh?= =?us-ascii?Q?W6pSVPM6WZj6eV9FdgqOWxhSWakkl6jumsRDDB94vczzrLXG1ufjdbUMbOGS?= =?us-ascii?Q?K+qCSWT1GWUvPqEZoXedAjXqtzyb1KvmcTAZ77hAoxyCGXRRHyFeuVG7yg0p?= =?us-ascii?Q?Wkh/NBRy3ODyH2dawgJEmzwyWn8oHC2E1jI15EUW/Q/Q4aoSr58OlgXaX9tG?= =?us-ascii?Q?NFSUHQCy816v6Xr/7jFQzwCMWevVT1O5iFZY8JtdAeZ+59BEz6vzitB8AcFl?= =?us-ascii?Q?6fbnne+lclObKx8Te+scm1180QpZsztxNPB7GPBHmEWuPxvQBdlRffWepr/U?= =?us-ascii?Q?usz3yumtdXTv7MAH+PLFZlieXyPsB14unNW2UdC3J+9fq7tO3V6aex0ObAsG?= =?us-ascii?Q?Q7vbea+ohTmovO84vrxxztSa0aI1BjueAa1XHS1RoZgBQaBBybaUO/7AXDlR?= =?us-ascii?Q?UwbhzLXxLtg1xC0TokZoIx3bJX6o1Ic6A+9wOBYW8I2EAJ4XZcfgKqGQgwlv?= =?us-ascii?Q?sDRkkoms3P/rhpyw3kfBTUXiyE3ggdK32WvxGTtElSXdTyuivrZ2XtufrILR?= =?us-ascii?Q?0p/prPj9OCM6uPOpVp8pOBdVdMRcGEPu0JHxHv4FDsTsCARe6wci635JXCT+?= =?us-ascii?Q?i0CgGB4UDvHOaov1Mv1bYXyoQwP4XGoHlLd9gxpsvhQNEiqYWEFIUGEWbedH?= =?us-ascii?Q?lo2Egm9uG8IwwmVOz25Lp2S/ZI36igSRT1VpnJnnGFFigMh6FYSBsRC0bMs6?= =?us-ascii?Q?wat3a7OeJuzX5UJekLcUSEuP3cSzRxikVHfRwZDUucOXLpxmd02+fW3aTdwo?= =?us-ascii?Q?0gc2YJIQXoJ1gkN59RhiIm1N8OHgNkkrqGNcLZnqmR2vfl1LXBtF8JPGDDdm?= =?us-ascii?Q?6+lgrEfpV+lHqPCwv53jdwqXQK8pzMp2KJePfCTD?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e66dec4-882e-4a29-8119-08ddfb40f9a7 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Sep 2025 08:04:24.1423 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Q1L+g+LWsP1qqcSes8JJe+xSY+/2Zi+sYM4I4+0gcske8bUYlOe18+7YeV62Ew/iranbKpneH2UkdolTmg8ubfDl03ezjtQqzrvNHU4kv0k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7193 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hello Tom, >> They are more different than it first appears. The gdbserver side >> accepts pN.-1, for example, while the gdb side doesn't. The gdb side >> doesn't accept -1 at all. > >> When the string does not start with 'p', both fall back to the >> respective inferior on either side, but gdb has special handling for a >> not-yet-known process id, whereas the gdbserver side doesn't. > > >I haven't been following this super closely, but there's also a bugzilla >bug in this area: > >https://sourceware.org/bugzilla/show_bug.cgi?id=3D25111 That seems to be caused by truncating a long ptid.tid to int before writing it out. In general, read_ptid() and write_ptid() don't seem to care about types and conversions; read_ptid(), for example, reads everything into ULONGEST and then constructs a ptid without checking for overflows. I could add a fix to this series, but, as with the other patches, this would be solely based on reviewing the code without an actual bug (I cannot test this zephyr target) nor a test. Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928