RE: [PATCH] [gdb.base] Add additional next commands for clang-12 and above in foll-exec.exp

["Kumar N, Bhuvanendra via Gdb-patches" <gdb-patches@sourceware.org>]

[AMD Official Use Only - Internal Distribution Only]

> So, let's do that then, there's less chance of it breaking again.

Thanks a lot, will send separate patch for this change(in foll-exec.c) then. I will make this change applicable for all compilers or default, not just for clang, which does not going to harm others, while it definitely helps clang

> 42   execlp (prog, /* tbreak-execlp */ prog, "execlp arg1 from foll-exec", (char *) 0);
> . . .
> 46   execl (prog,  /* tbreak-execl */ prog, "execl arg1 from foll-exec", "execl arg2 from foll-exec", (char *) 0);

regards,
bhuvan

-----Original Message-----
From: Simon Marchi <simon.marchi@polymtl.ca> 
Sent: Tuesday, June 1, 2021 7:21 PM
To: Kumar N, Bhuvanendra <Bhuvanendra.KumarN@amd.com>; gdb-patches@sourceware.org
Cc: George, Jini Susan <JiniSusan.George@amd.com>; Achra, Nitika <Nitika.Achra@amd.com>; Sharma, Alok Kumar <AlokKumar.Sharma@amd.com>; E, Nagajyothi <Nagajyothi.E@amd.com>; Tomar, Sourabh Singh <SourabhSingh.Tomar@amd.com>
Subject: Re: [PATCH] [gdb.base] Add additional next commands for clang-12 and above in foll-exec.exp

[CAUTION: External Email]

> I used my email client (which is Microsoft outlook) for submitting the 
> patch for review. I am reattaching the same old patch(sent on 
> 2021-04-15) as an attachment this time, in case if it helps for you

Thanks, that's better, at least I can apply the patch.  However, please consider using git-send-email, that makes it much easier to send review comments.

>> Does it work if we just put the whole execlp call on a single line instead?
>
> Yes, it works fine. if we are putting everything under one line as shred below, then it works fine with existing foll-exec.exp itself and no further change is required to foll-exec.exp.
>
> 42   execlp (prog, /* tbreak-execlp */ prog, "execlp arg1 from foll-exec", (char *) 0);
> . . .
> 46   execl (prog,  /* tbreak-execl */ prog, "execl arg1 from foll-exec", "execl arg2 from foll-exec", (char *) 0);

So, let's do that then, there's less chance of it breaking again.

Simon