From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id R/VrJklVtmCvYQAAWB0awg (envelope-from ) for ; Tue, 01 Jun 2021 11:42:01 -0400 Received: by simark.ca (Postfix, from userid 112) id 9347C1F163; Tue, 1 Jun 2021 11:42:01 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 348131E01F for ; Tue, 1 Jun 2021 11:42:01 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9623F3861834 for ; Tue, 1 Jun 2021 15:42:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9623F3861834 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1622562120; bh=4AyA4ij4Z7smaX493wS8JFcqKYdnehdHxtJqiFJIUWY=; h=To:Subject:Date:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=alWjN6CzOfDTxGeuFTIzvS9pf8Tx1TPdYOIq0W/6VHZNW8y14RcfWDpSBSVqPyUqp wabz85nozV2EK01lMdIBYI1E56IXISmxhiHGErBsfb4DsrrzuEIS/d6fyU3WGY20gr B+2qiAkfuYVyqstfAjop1gQRK36zpaoDgthUHBIE= Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2060.outbound.protection.outlook.com [40.107.101.60]) by sourceware.org (Postfix) with ESMTPS id 564E33855006 for ; Tue, 1 Jun 2021 15:40:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 564E33855006 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j1CxIASQZBONkQt+OTG7/Il2XVgSwxjkZ3k++fV0JCgko0Xx7BN8ExwqhsXhkBvK/Usv9WrKCnxZlB2FVT5AcS2u5WUvaR5n+HJhs6HoWvIvCx6wvfStUHBUPjexlrqXqTrvlDxaknLZm1TYTmLo3lJORqdKJw4VaUailbNEAyldFxnCVQQYmTcyISbM3Tn25UF9pYy7xcUUaI6j4vqyiX4JGX0dvARnqe/GBsu7xSKUUNU6WZMGqcMLWpbb/wfUnN+6xeC0FOpP+drdnBgnEu1PYj2X93RUt1MINnafSFxrZUT7eTwkg/vQ50hwVWFroSwKW3PT2XtBIYjBXDRzlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4AyA4ij4Z7smaX493wS8JFcqKYdnehdHxtJqiFJIUWY=; b=gJ80ufsxPdlIHPfXMV4Am7P9BSHBSpJXi+DlNYq+AI/eKGBVCWwMQBu9pQQG0mltTSEUB8Z0vCgUtfp8YpkOncqk81DCPr8qXFMYK9uOGpAf5MmUBZigyjoWCjlWx0lLuI2qhWRhEmCKyeD5dSjpHd2tAc7/P4WUpEyUBbMTs3r4Bco4j9S61P6tnRwnysl0V5iVbZok3XXiQfyzX7xkZgyj8ifOiaXg+tswvzbUSn1EVcXZAjr1rR75AsBzXMnNWcjqeck/PuVXSDFVJEczswk32wRSkUOMhFFE17UdNp67KxAgTQbTKjyjfAvK9Thhlwo6wTMKTT4mkyYcAr8y7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM5PR12MB1450.namprd12.prod.outlook.com (2603:10b6:4:3::8) by DM6PR12MB4530.namprd12.prod.outlook.com (2603:10b6:5:2aa::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.20; Tue, 1 Jun 2021 15:40:31 +0000 Received: from DM5PR12MB1450.namprd12.prod.outlook.com ([fe80::ec05:c009:c3be:d2e2]) by DM5PR12MB1450.namprd12.prod.outlook.com ([fe80::ec05:c009:c3be:d2e2%6]) with mapi id 15.20.4173.030; Tue, 1 Jun 2021 15:40:31 +0000 To: Simon Marchi , "gdb-patches@sourceware.org" Subject: RE: [PATCH] [gdb.base] Add additional next commands for clang-12 and above in foll-exec.exp Thread-Topic: [PATCH] [gdb.base] Add additional next commands for clang-12 and above in foll-exec.exp Thread-Index: AdcyLoQ1lkRAo39xTB+he/vftbq7zAiArWOAAKjqyCAABg4cgAADcppQ Date: Tue, 1 Jun 2021 15:40:31 +0000 Message-ID: References: <50265efc-2fa2-8bb4-7285-60fa32b8ead2@polymtl.ca> <6d557aed-4f2f-9f07-1b00-9c970cf75ec6@polymtl.ca> In-Reply-To: <6d557aed-4f2f-9f07-1b00-9c970cf75ec6@polymtl.ca> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Enabled=true; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_SetDate=2021-06-01T15:40:21Z; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Method=Standard; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Name=Internal Use Only - Unrestricted; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_ActionId=bf833f5e-219b-4db3-804b-644ddc01d532; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_ContentBits=1 msip_justification: I confirm the recipients are approved for sharing this content x-originating-ip: [2406:7400:73:62d8:b819:a940:45a2:9459] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ce92c173-97ce-43af-bd97-08d925139706 x-ms-traffictypediagnostic: DM6PR12MB4530: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mZDAHM1BIgcfVhJ2Tn9k6PcMAvHeECYIUl4VSrCrcEuGY6NQMD4O0JnEYSe7yjiauptiMBbTztLjGwiopK4bM0I8csN/yY3StBCt5n6W1ByvFxlW271KYjWXCM0BS4tTVh+NScgiqn7MFkUK6bcSW0jQf0RuFkDLAWYZLY7MJCFiPU1mbZjAM7TWEgzYeYjv5gY5YYt3w011rfQ91X7U2l41nyA366wRiURs12qvYxQ0u+8xoJTPt+4lXtlJl3raHk1UXVbBi5IYnW8K8OshB7DdQosz2cs/zDMJxnNtHkexicUEv187JXDQMiTvqyGW45DePBTdD3ch3fE/5pe6F+nj1oMn2XTafEuwE2uEtYs7fWy5TaNpLHRfWVdmMhzWocxf6QyrVJitsFmgg/j9+c8z5QsUuq2JhECHuH3PN8DbzZr0+D+TIsuBTDvXH7w/0ovr7l2mb4XfhHsE5m5ZuH75uUvxU7K8SimL2rlv4I5pc5VgGhSjxZaTxV+DGovBTnwxJ5udgO7WEWpleZvUMCYuqqWBPFAAxQtcf5ZZbhzs1r+KflKnRMetu2yriEYDTO+DjNeepy8gdSuZEL8NgKNLDFGMDDgpKx74ok8VALg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR12MB1450.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(376002)(346002)(136003)(39860400002)(86362001)(6506007)(52536014)(53546011)(45080400002)(478600001)(2906002)(316002)(9686003)(83380400001)(186003)(8936002)(33656002)(66946007)(66446008)(66476007)(76116006)(71200400001)(38100700002)(55016002)(122000001)(7696005)(8676002)(64756008)(5660300002)(66556008)(54906003)(110136005)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?FCWaLmObTgqEKBEnnWsmiElSGCCjJZ8+6X539LnFm9tzk2d2RZe2T6j0VP/t?= =?us-ascii?Q?fLyFd33Ab9Mu3veG0vGsxZraBgsvqhHPVPXit3G5PcHfCvy6gOfUgM0dRkUt?= =?us-ascii?Q?+GpffWzBZ4z75wvVviSTs3s5TA5pn45Gtw4phCBn9CsAn9BeZUo/CFgSUJWd?= =?us-ascii?Q?3qyqjm68nEFZZa7UrpRUHbYAZHMBFonktGTeOf5KyfI0TLHRvayU+I+Qv9oZ?= =?us-ascii?Q?eqA1aT2tchglbK0BLnz/E2/+1mr1nfnLxGOzYDbMvxcN87ntxrYKydcVwFYJ?= =?us-ascii?Q?RVkIzJotjvVX5PxPeg8F6q0z3h4tn0341ib7TxOYQryw6PkpgDsGE/cXn6Ez?= =?us-ascii?Q?pZ7cd9/3vVfINas0dwLvHLcgSKt2xu7Wzw0vqHrFugzaoAeDMt9nezdkuL5Y?= =?us-ascii?Q?6uEvLjXApqrqbbeze3BC3Vkgj6TsUUzieZQfe8uzzgxcOeptnrlYPIl+rI52?= =?us-ascii?Q?b0xNELWmUbBFaX+vQ0slJygvdLcas9G2602uhw5hKuAF38Hc4CJQnaBxxV/L?= =?us-ascii?Q?xGB5neh4XrdXTdJxen6MDS4xYERz1rbbuxddKDz0uzcVddYZ3hez48PMXU1R?= =?us-ascii?Q?Ud6EMy8/LtqrPnAu6TFHBGfv8Y+o0NJwsXKopnc4mdX2ASh6JKzFLonW28ke?= =?us-ascii?Q?KiMMbOOBLJCxV5j1UyXQ4BsY7kIIIXhcj5XPVV4FCk9hPeki4OgsoXUUecyl?= =?us-ascii?Q?vpTB8ad59Tfl9+wu6fo30I1hBVxOwE/7J65/hxPXc8dhQPxqhE9dRw4Ueiqf?= =?us-ascii?Q?VpqNkckrKIjxEncgYyHJb9lAXouhaQxV1+EgnsYCxh8c+XuJPSp8xJuRAVJj?= =?us-ascii?Q?RznHnufZt41+a2itiygufBmPzPBohwOa6x0EgI7scpRg6oUDT50H4IfD+hH/?= =?us-ascii?Q?x0L7PrA9g+WlpNH+e3HAiSyj3bB2qoWqCVP+QIZeyUKgnQa/4pEwmLYy2uQb?= =?us-ascii?Q?Dw8h9WObGwiXoVmZ9zYHSEGS7wUUiW1U0OQ6JmCee1fDeE5xnW2KQAqEpNjS?= =?us-ascii?Q?FCf73NIgBMW8LyTkYrRsZqSq7dIrU99xjfDMuFdHtgf0n+m/UBQKyDamcp/+?= =?us-ascii?Q?szNZrihMVgaFK9YOqQU8g49SVycO5xTIymjP3VaZ0gIRw8NgzsYPBsyzJRV7?= =?us-ascii?Q?RfaqK9ieCsIECkrhl4hjJZW7hpmBMUyyV5XiSfw/1N30dOnQ2YZxj8PBvLpc?= =?us-ascii?Q?tePs9mLI6Cw1LJ4fqgRrswpMJlglZZUPEe0UAkK+o2+1fp3dntdR5dKZX7kj?= =?us-ascii?Q?H8T+wdlVV/2ZGhI22HXjlZBLcaZ6/tUIeFnytWQtGtVrq+pMpJ7Fa98AmzNX?= =?us-ascii?Q?YAb2o/2wa30Hy55R+04vIM9nwTcb0SXO0QwuQgKgM+7wKX7BI7AimPTBRA6w?= =?us-ascii?Q?rQ3irmSENtaN+P3JJeAB6ilcW3UB?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1450.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce92c173-97ce-43af-bd97-08d925139706 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jun 2021 15:40:31.6634 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9lop1Kvpe/QxU9HycohpzLuxIb+4MXoKsPrhk0mcbHIe7GA+N+GnW3DYwIGOy1pVTLTcVsKEyppl6j8QL33fqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4530 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Kumar N, Bhuvanendra via Gdb-patches" Reply-To: "Kumar N, Bhuvanendra" Cc: "George, Jini Susan" , "Achra, Nitika" , "Sharma, Alok Kumar" , "Tomar, Sourabh Singh" , "E, Nagajyothi" Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" [AMD Official Use Only - Internal Distribution Only] > So, let's do that then, there's less chance of it breaking again. Thanks a lot, will send separate patch for this change(in foll-exec.c) then= . I will make this change applicable for all compilers or default, not just= for clang, which does not going to harm others, while it definitely helps = clang > 42 execlp (prog, /* tbreak-execlp */ prog, "execlp arg1 from foll-exec"= , (char *) 0); > . . . > 46 execl (prog, /* tbreak-execl */ prog, "execl arg1 from foll-exec", = "execl arg2 from foll-exec", (char *) 0); regards, bhuvan -----Original Message----- From: Simon Marchi =20 Sent: Tuesday, June 1, 2021 7:21 PM To: Kumar N, Bhuvanendra ; gdb-patches@sourcewa= re.org Cc: George, Jini Susan ; Achra, Nitika ; Sharma, Alok Kumar ; E, Nagajyothi = ; Tomar, Sourabh Singh Subject: Re: [PATCH] [gdb.base] Add additional next commands for clang-12 a= nd above in foll-exec.exp [CAUTION: External Email] > I used my email client (which is Microsoft outlook) for submitting the=20 > patch for review. I am reattaching the same old patch(sent on=20 > 2021-04-15) as an attachment this time, in case if it helps for you Thanks, that's better, at least I can apply the patch. However, please con= sider using git-send-email, that makes it much easier to send review commen= ts. >> Does it work if we just put the whole execlp call on a single line inste= ad? > > Yes, it works fine. if we are putting everything under one line as shred = below, then it works fine with existing foll-exec.exp itself and no further= change is required to foll-exec.exp. > > 42 execlp (prog, /* tbreak-execlp */ prog, "execlp arg1 from foll-exec"= , (char *) 0); > . . . > 46 execl (prog, /* tbreak-execl */ prog, "execl arg1 from foll-exec", = "execl arg2 from foll-exec", (char *) 0); So, let's do that then, there's less chance of it breaking again. Simon