Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: "Kumar N, Bhuvanendra" <Bhuvanendra.KumarN@amd.com>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: "George, Jini Susan" <JiniSusan.George@amd.com>,
	"Achra, Nitika" <Nitika.Achra@amd.com>,
	"Sharma, Alok Kumar" <AlokKumar.Sharma@amd.com>,
	"Tomar, Sourabh Singh" <SourabhSingh.Tomar@amd.com>,
	"E, Nagajyothi" <Nagajyothi.E@amd.com>
Subject: Re: [PATCH] [gdb.base] Add additional next commands for clang-12 and above in foll-exec.exp
Date: Tue, 1 Jun 2021 09:50:43 -0400	[thread overview]
Message-ID: <6d557aed-4f2f-9f07-1b00-9c970cf75ec6@polymtl.ca> (raw)
In-Reply-To: <DM5PR12MB1450BAD6325002143B061043873E9@DM5PR12MB1450.namprd12.prod.outlook.com>

> I used my email client (which is Microsoft outlook) for submitting the patch for review. I am reattaching the same old patch(sent on 2021-04-15) as an attachment this time, in case if it helps for you

Thanks, that's better, at least I can apply the patch.  However, please
consider using git-send-email, that makes it much easier to send review
comments.

>> Does it work if we just put the whole execlp call on a single line instead?
> 
> Yes, it works fine. if we are putting everything under one line as shred below, then it works fine with existing foll-exec.exp itself and no further change is required to foll-exec.exp.
> 
> 42   execlp (prog, /* tbreak-execlp */ prog, "execlp arg1 from foll-exec", (char *) 0);
> . . .
> 46   execl (prog,  /* tbreak-execl */ prog, "execl arg1 from foll-exec", "execl arg2 from foll-exec", (char *) 0);

So, let's do that then, there's less chance of it breaking again.

Simon

  reply	other threads:[~2021-06-01 13:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15 19:37 Kumar N, Bhuvanendra via Gdb-patches
2021-04-30  8:59 ` Kumar N, Bhuvanendra via Gdb-patches
2021-05-26  8:00   ` Kumar N, Bhuvanendra via Gdb-patches
2021-05-29  2:20 ` Simon Marchi via Gdb-patches
2021-06-01 11:10   ` Kumar N, Bhuvanendra via Gdb-patches
2021-06-01 13:50     ` Simon Marchi via Gdb-patches [this message]
2021-06-01 15:40       ` Kumar N, Bhuvanendra via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d557aed-4f2f-9f07-1b00-9c970cf75ec6@polymtl.ca \
    --to=gdb-patches@sourceware.org \
    --cc=AlokKumar.Sharma@amd.com \
    --cc=Bhuvanendra.KumarN@amd.com \
    --cc=JiniSusan.George@amd.com \
    --cc=Nagajyothi.E@amd.com \
    --cc=Nitika.Achra@amd.com \
    --cc=SourabhSingh.Tomar@amd.com \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox